Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(customElement): should properly patch as props for vue custom elements #12409

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(customElement): should properly patch as props for vue custom elements #12409

wants to merge 1 commit into from

Conversation

lejunyang
Copy link

close #12408

@lejunyang lejunyang changed the title fix(runtime-dom): should properly patch as props for vue custom eleme… fix(runtime-dom): should properly patch as props for vue custom elements Nov 18, 2024
@edison1105 edison1105 added need more info Further information is requested 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: custom elements labels Nov 18, 2024
@edison1105 edison1105 changed the title fix(runtime-dom): should properly patch as props for vue custom elements fix(customElement): should properly patch as props for vue custom elements Nov 18, 2024
@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+34 B) 37.9 kB (+8 B) 34.2 kB (+6 B)
vue.global.prod.js 158 kB (+34 B) 57.8 kB (+12 B) 51.5 kB (+51 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB (+34 B) 18.4 kB (+15 B) 16.8 kB (+5 B)
createApp 55.2 kB (+34 B) 21.4 kB (+14 B) 19.5 kB (+21 B)
createSSRApp 59.3 kB (+34 B) 23.1 kB (+17 B) 21 kB (+10 B)
defineCustomElement 60.1 kB (+36 B) 22.9 kB (+10 B) 20.9 kB (+19 B)
overall 69.1 kB (+34 B) 26.5 kB (+6 B) 24.1 kB (-6 B)

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 18, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12409

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12409

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12409

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12409

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12409

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12409

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12409

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12409

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12409

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12409

vue

pnpm add https://pkg.pr.new/vue@12409

commit: 1f0062c

@edison1105 edison1105 added ready to merge The PR is ready to be merged. and removed need more info Further information is requested labels Nov 18, 2024
@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Nov 18, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools ✅ success ✅ success
nuxt ✅ success ✅ success
pinia ✅ success ✅ success
primevue ✅ success ✅ success
quasar ✅ success ✅ success
radix-vue ✅ success ✅ success
router ✅ success ✅ success
test-utils ✅ success ✅ success
vant ✅ success ✅ success
vite-plugin-vue ✅ success ✅ success
vitepress ✅ success ✅ success
vue-i18n ✅ success ✅ success
vue-macros ✅ success ✅ success
vuetify ✅ success ✅ success
vueuse ✅ success ✅ success
vue-simple-compiler ✅ success ✅ success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105 edison1105 left review comments

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: custom elements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot properly set numberish attribute(like tabindex) or boolean attribute on Vue custom element
3 participants
@lejunyang @edison1105 @vue-bot