Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): support using other prop as default value in props destructuring #12387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

close #12386

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 21 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Nov 14, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12387

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12387

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12387

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12387

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12387

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12387

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12387

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12387

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12387

vue

pnpm add https://pkg.pr.new/vue@12387

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12387

commit: 038dc1e

@edison1105 edison1105 changed the title fix(compile-sfc): support use other prop as default value in props destructuring fix(compiler-sfc): support use other prop as default value in props destructuring Nov 14, 2024
@edison1105 edison1105 changed the title fix(compiler-sfc): support use other prop as default value in props destructuring fix(compiler-sfc): support using other prop as default value in props destructuring Nov 14, 2024
@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Nov 14, 2024
@vue-bot
Copy link
Contributor

vue-bot commented Nov 14, 2024

⏳ Triggered ecosystem CI: Open

@vue-bot
Copy link
Contributor

vue-bot commented Nov 14, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@skirtles-code
Copy link
Contributor

Do you think a use case like this should be supported?

const { items, start = 0, end = items.length } = defineProps<{
  items: string[],
  start?: number,
  end?: number
}>()

I'm also wondering about the impact of prop ordering. For example, this will work:

const { a = 0, b = a } = defineProps<{
  a?: number,
  b?: number,
}>()

But this (with a and b flipped in the type) won't:

const { a = 0, b = a } = defineProps<{
  b?: number,
  a?: number,
}>()

In some ways this isn't a new problem, as the ordering has always mattered, but it's maybe less intuitive when the defaults are being applied via props destructuring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use prop as default value for other prop with props destructuring const { foo, bar = foo }
3 participants