Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The file path is encoded into the digest (and, is the name really needed?) #24

Open
urjaman opened this issue Jun 21, 2024 · 0 comments

Comments

@urjaman
Copy link

urjaman commented Jun 21, 2024

... and asignify check requires to be given the same path when checking a digest, or else it will not find the file in the digest. Ugh, this is not very user friendly.

I mean, relative directories might be useful if we're signing a whole directory tree (and there are multiple files with the same name in different subdirs), but then the code should be way smarter (as in, normalize all paths, find the "root point", only match the path components past the root point when checking, etc.), but I don't see any intent to support directories in the code, just "file1 file2" so using asignify like this would be difficult (one would need to use other tools to generate the file list of the whole tree.)

Anyways, I think it should be possible to have a 1-file signature without any filename inside, just the hash (as in, "BLAKE2 = abcdef..."), and asignify check should try the nameless hash for the first file given.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant