Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CLI option --parallel to --threads #80

Closed
fkoksal opened this issue Apr 16, 2024 · 2 comments · Fixed by #81
Closed

Rename CLI option --parallel to --threads #80

fkoksal opened this issue Apr 16, 2024 · 2 comments · Fixed by #81
Assignees
@vst
Labels
bug Something isn't working

Comments

@fkoksal
Copy link

fkoksal commented Apr 16, 2024 •
edited by vst
Loading

The option --parallel expects an argument despite --help claims the default is 4.
@fkoksal
Copy link
Author

fkoksal commented Apr 16, 2024

I guess, I misunderstood the argument parallel. It works parallel by default.
It might be better to change the name of the argument to thread-count or similar...

@vst
Copy link
Owner

vst commented Apr 16, 2024

Yep. Makes sense...

@vst vst changed the title The option --parallel expects an argument despite --help claims the default is 4 Rename CLI option --parallel to --threads Apr 16, 2024
@vst vst self-assigned this Apr 16, 2024
@vst vst added the bug Something isn't working label Apr 16, 2024
vst added a commit that referenced this issue Apr 17, 2024
@vst
fix: rename --parallel option to --threads for clarity
6373e25 
Closes #80.
@vst vst mentioned this issue Apr 17, 2024
Merged
@vst vst linked a pull request Apr 17, 2024 that will close this issue
fix: rename --parallel option to --threads for clarity #81
Merged
@vst vst closed this as completed in #81 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vst vst

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: rename --parallel option to --threads for clarity vst/hostpatrol
2 participants
@vst @fkoksal