From b4d3434febd46360c2391816523c224ae8ea4ed8 Mon Sep 17 00:00:00 2001 From: Sebastian Widmer Date: Fri, 25 Mar 2022 09:42:49 +0100 Subject: [PATCH] Merge keycloak user on the client side --- go.mod | 2 +- go.sum | 22 -------- keycloak/client.go | 7 ++- keycloak/client_put_user_test.go | 37 +++++++------ keycloak/user.go | 48 +++++------------ keycloak/user_test.go | 89 +++++++++++++++++--------------- 6 files changed, 81 insertions(+), 124 deletions(-) diff --git a/go.mod b/go.mod index 67e19f5..a291f16 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/vshn/appuio-keycloak-adapter -go 1.17 +go 1.18 require ( github.com/Nerzal/gocloak/v11 v11.0.2 diff --git a/go.sum b/go.sum index 61aef73..13a2ec0 100644 --- a/go.sum +++ b/go.sum @@ -142,7 +142,6 @@ github.com/canonical/go-dqlite v1.5.1/go.mod h1:wp00vfMvPYgNCyxcPdHB5XExmDoCGoPU github.com/census-instrumentation/opencensus-proto v0.2.1/go.mod h1:f6KPmirojxKA12rnyqOA5BBL4O983OfeGPqjHWSTneU= github.com/certifi/gocertifi v0.0.0-20191021191039-0944d244cd40/go.mod h1:sGbDF6GwGcLpkNXPUTkMRoywsNa/ol15pxFe6ERfguA= github.com/certifi/gocertifi v0.0.0-20200922220541-2c3bb06c6054/go.mod h1:sGbDF6GwGcLpkNXPUTkMRoywsNa/ol15pxFe6ERfguA= -github.com/cespare/xxhash v1.1.0 h1:a6HrQnmkObjyL+Gs60czilIUGqrzKutQD6XZog3p+ko= github.com/cespare/xxhash v1.1.0/go.mod h1:XrSqR1VqqWfGrhpAt58auRo0WTKS1nRRg3ghfAqPWnc= github.com/cespare/xxhash/v2 v2.1.1 h1:6MnRN8NT7+YBpUIWxHtefFZOKTAPgGjpQSxqLNn0+qY= github.com/cespare/xxhash/v2 v2.1.1/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs= @@ -687,17 +686,13 @@ github.com/onsi/ginkgo v1.10.3/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+ github.com/onsi/ginkgo v1.12.1/go.mod h1:zj2OWP4+oCPe1qIXoGWkgMRwljMUYCdkwsT2108oapk= github.com/onsi/ginkgo v1.14.0/go.mod h1:iSB4RoI2tjJc9BBv4NKIKWKya62Rps+oPG/Lv9klQyY= github.com/onsi/ginkgo v1.16.1/go.mod h1:CObGmKUOKaSC0RjmoAK7tKyn4Azo5P2IWuoMnvwxz1E= -github.com/onsi/ginkgo v1.16.4/go.mod h1:dX+/inL/fNMqNlz0e9LfyB9TswhZpCVdJM/Z6Vvnwo0= github.com/onsi/ginkgo v1.16.5 h1:8xi0RTUf59SOSfEtZMvwTvXYMzG4gV23XVHOZiXNtnE= -github.com/onsi/ginkgo v1.16.5/go.mod h1:+E8gABHa3K6zRBolWtd+ROzc/U5bkGt0FwiG042wbpU= github.com/onsi/gomega v0.0.0-20170829124025-dcabb60a477c/go.mod h1:C1qb7wdrVGGVU+Z6iS04AVkA3Q65CEZX59MT0QO5uiA= github.com/onsi/gomega v1.7.0/go.mod h1:ex+gbHU/CVuBBDIJjb2X0qEXbFg53c61hWP/1CpauHY= github.com/onsi/gomega v1.7.1/go.mod h1:XdKZgCCFLUoM/7CFJVPcG8C1xQ1AJ0vpAezJrB7JYyY= github.com/onsi/gomega v1.10.1/go.mod h1:iN09h71vgCQne3DLsj+A5owkum+a2tYe+TOCB1ybHNo= github.com/onsi/gomega v1.11.0/go.mod h1:azGKhqFUon9Vuj0YmTfLSmx0FUwqXYSTl5re8lQLTUg= -github.com/onsi/gomega v1.14.0/go.mod h1:cIuvLEne0aoVhAgh/O6ac0Op8WWw9H6eYCriF+tEHG0= github.com/onsi/gomega v1.17.0 h1:9Luw4uT5HTjHTN8+aNcSThgH1vdXnmdJ8xIfZ4wyTRE= -github.com/onsi/gomega v1.17.0/go.mod h1:HnhC7FXeEQY45zxNK3PPoIUhzk/80Xly9PcubAlGdZY= github.com/opentracing/opentracing-go v1.1.0/go.mod h1:UkNAQd3GIcIGf0SeVgPpRdFStlNbqXla1AfSYxPUl2o= github.com/opentracing/opentracing-go v1.2.0 h1:uEJPy/1a5RIPAJ0Ov+OIO8OxWu77jEv+1B0VhjKrZUs= github.com/opentracing/opentracing-go v1.2.0/go.mod h1:GxEUsuufX4nBwe+T+Wl9TAgYrxe9dPLANfrWvHYVTgc= @@ -937,14 +932,11 @@ go.uber.org/atomic v1.5.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ= go.uber.org/atomic v1.7.0 h1:ADUqmZGgLDDfbSL9ZmPxKTybcoEYHgpYfELNoN+7hsw= go.uber.org/atomic v1.7.0/go.mod h1:fEN4uk6kAWBTFdckzkM89CLk9XfWZrxpCo0nPH17wJc= go.uber.org/goleak v1.1.10/go.mod h1:8a7PlsEVH3e/a/GLqe5IIrQx6GzcnRmZEufDUTk4A7A= -go.uber.org/goleak v1.1.11-0.20210813005559-691160354723/go.mod h1:cwTWslyiVhfpKIDGSZEM2HlOvcqm+tG4zioyIeLoqMQ= go.uber.org/goleak v1.1.11/go.mod h1:cwTWslyiVhfpKIDGSZEM2HlOvcqm+tG4zioyIeLoqMQ= go.uber.org/goleak v1.1.12 h1:gZAh5/EyT/HQwlpkCy6wTpqfH9H8Lz8zbm3dZh+OyzA= -go.uber.org/goleak v1.1.12/go.mod h1:cwTWslyiVhfpKIDGSZEM2HlOvcqm+tG4zioyIeLoqMQ= go.uber.org/multierr v1.1.0/go.mod h1:wR5kodmAFQ0UK8QlbwjlSNy0Z68gJhDJUG5sjR94q/0= go.uber.org/multierr v1.3.0/go.mod h1:VgVr7evmIr6uPjLBxg28wmKNXyqE9akIJ5XnfpiKl+4= go.uber.org/multierr v1.4.0/go.mod h1:VgVr7evmIr6uPjLBxg28wmKNXyqE9akIJ5XnfpiKl+4= -go.uber.org/multierr v1.6.0 h1:y6IPFStTAIT5Ytl7/XYmHvzXQ7S3g/IeZW9hyZ5thw4= go.uber.org/multierr v1.6.0/go.mod h1:cdWPpRnG4AhwMwsgIHip0KRBQjJy5kYEpYjJxpXp9iU= go.uber.org/multierr v1.8.0 h1:dg6GjLku4EH+249NNmoIciG9N/jURbDG+pFlTkhzIC8= go.uber.org/multierr v1.8.0/go.mod h1:7EAYxJLBy9rStEaz58O2t4Uvip6FSURkq8/ppBp95ak= @@ -953,7 +945,6 @@ go.uber.org/zap v1.10.0/go.mod h1:vwi/ZaCAaUcBkycHslxD9B2zi4UTXhF60s6SWpuDF0Q= go.uber.org/zap v1.13.0/go.mod h1:zwrFLgMcdUuIBviXEYEH1YKNaOBnKXsx2IPda5bBwHM= go.uber.org/zap v1.17.0/go.mod h1:MXVU+bhUf/A7Xi2HNOnopQOrmycQ5Ih87HtOu4q5SSo= go.uber.org/zap v1.19.0/go.mod h1:xg/QME4nWcxGxrpdeYfq7UvYrLh66cuVKdrbD1XF/NI= -go.uber.org/zap v1.19.1/go.mod h1:j3DNczoxDZroyBnOT1L/Q79cfUMGZxlv/9dzN7SM1rI= go.uber.org/zap v1.20.0 h1:N4oPlghZwYG55MlU6LXk/Zp00FVNE9X9wrYO8CEs4lc= go.uber.org/zap v1.20.0/go.mod h1:wjWOCqI0f2ZZrJF/UufIOkiC8ii6tm1iqIsLo76RfJw= golang.org/x/crypto v0.0.0-20180501155221-613d6eafa307/go.mod h1:6SG95UA2DQfeDnfUPMdvaQW0Q7yPrPDi9nlGo2tz2b4= @@ -1068,7 +1059,6 @@ golang.org/x/net v0.0.0-20210119194325-5f4716e94777/go.mod h1:m0MpNAwzfU5UDzcl9v golang.org/x/net v0.0.0-20210226172049-e18ecbb05110/go.mod h1:m0MpNAwzfU5UDzcl9v0D8zg8gWTRqZa9RBIspLL5mdg= golang.org/x/net v0.0.0-20210316092652-d523dce5a7f4/go.mod h1:RBQZq4jEuRlivfhVLdyRGr576XBO4/greRjx4P4O3yc= golang.org/x/net v0.0.0-20210405180319-a5a99cb37ef4/go.mod h1:p54w0d4576C0XHj96bSt6lcn1PtDYWL6XObtHCRCNQM= -golang.org/x/net v0.0.0-20210428140749-89ef3d95e781/go.mod h1:OJAsFXCWl8Ukc7SiCT/9KSuxbyM7479/AVlXFRxuMCk= golang.org/x/net v0.0.0-20210520170846-37e1c6afe023/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y= golang.org/x/net v0.0.0-20210525063256-abc453219eb5/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y= golang.org/x/net v0.0.0-20210805182204-aaa1db679c0d/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y= @@ -1499,42 +1489,35 @@ honnef.co/go/tools v0.0.1-2020.1.4/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9 honnef.co/go/tools v0.2.0/go.mod h1:lPVVZ2BS5TfnjLyizF7o7hv7j9/L+8cZY2hLyjP9cGY= k8s.io/api v0.17.0/go.mod h1:npsyOePkeP0CPwyGfXDHxvypiYMJxBWAMpQxCaJ4ZxI= k8s.io/api v0.22.1/go.mod h1:bh13rkTp3F1XEaLGykbyRD2QaTTzPm0e/BMd8ptFONY= -k8s.io/api v0.22.2/go.mod h1:y3ydYpLJAaDI+BbSe2xmGcqxiWHmWjkEeIbiwHvnPR8= k8s.io/api v0.23.0/go.mod h1:8wmDdLBHBNxtOIytwLstXt5E9PddnZb0GaMcqsvDBpg= k8s.io/api v0.23.2/go.mod h1:sYuDb3flCtRPI8ghn6qFrcK5ZBu2mhbElxRE95qpwlI= k8s.io/api v0.23.5 h1:zno3LUiMubxD/V1Zw3ijyKO3wxrhbUF1Ck+VjBvfaoA= k8s.io/api v0.23.5/go.mod h1:Na4XuKng8PXJ2JsploYYrivXrINeTaycCGcYgF91Xm8= k8s.io/apiextensions-apiserver v0.17.0/go.mod h1:XiIFUakZywkUl54fVXa7QTEHcqQz9HG55nHd1DCoHj8= -k8s.io/apiextensions-apiserver v0.22.2/go.mod h1:2E0Ve/isxNl7tWLSUDgi6+cmwHi5fQRdwGVCxbC+KFA= k8s.io/apiextensions-apiserver v0.23.0 h1:uii8BYmHYiT2ZTAJxmvc3X8UhNYMxl2A0z0Xq3Pm+WY= k8s.io/apiextensions-apiserver v0.23.0/go.mod h1:xIFAEEDlAZgpVBl/1VSjGDmLoXAWRG40+GsWhKhAxY4= k8s.io/apimachinery v0.17.0/go.mod h1:b9qmWdKlLuU9EBh+06BtLcSf/Mu89rWL33naRxs1uZg= k8s.io/apimachinery v0.22.1/go.mod h1:O3oNtNadZdeOMxHFVxOreoznohCpy0z6mocxbZr7oJ0= -k8s.io/apimachinery v0.22.2/go.mod h1:O3oNtNadZdeOMxHFVxOreoznohCpy0z6mocxbZr7oJ0= k8s.io/apimachinery v0.23.0/go.mod h1:fFCTTBKvKcwTPFzjlcxp91uPFZr+JA0FubU4fLzzFYc= k8s.io/apimachinery v0.23.2/go.mod h1:zDqeV0AK62LbCI0CI7KbWCAYdLg+E+8UXJ0rIz5gmS8= k8s.io/apimachinery v0.23.5 h1:Va7dwhp8wgkUPWsEXk6XglXWU4IKYLKNlv8VkX7SDM0= k8s.io/apimachinery v0.23.5/go.mod h1:BEuFMMBaIbcOqVIJqNZJXGFTP4W6AycEpb5+m/97hrM= k8s.io/apiserver v0.17.0/go.mod h1:ABM+9x/prjINN6iiffRVNCBR2Wk7uY4z+EtEGZD48cg= k8s.io/apiserver v0.22.1/go.mod h1:2mcM6dzSt+XndzVQJX21Gx0/Klo7Aen7i0Ai6tIa400= -k8s.io/apiserver v0.22.2/go.mod h1:vrpMmbyjWrgdyOvZTSpsusQq5iigKNWv9o9KlDAbBHI= k8s.io/apiserver v0.23.0/go.mod h1:Cec35u/9zAepDPPFyT+UMrgqOCjgJ5qtfVJDxjZYmt4= k8s.io/apiserver v0.23.2 h1:vGFCojjwSLyunapA7FWuzyekml/s0nAsoh4iBpzWzOs= k8s.io/apiserver v0.23.2/go.mod h1:Kdt8gafkPev9Gfh+H6lCPbmRu42f7BfhOfHKKa3dtyU= k8s.io/client-go v0.17.0/go.mod h1:TYgR6EUHs6k45hb6KWjVD6jFZvJV4gHDikv/It0xz+k= k8s.io/client-go v0.22.1/go.mod h1:BquC5A4UOo4qVDUtoc04/+Nxp1MeHcVc1HJm1KmG8kk= -k8s.io/client-go v0.22.2/go.mod h1:sAlhrkVDf50ZHx6z4K0S40wISNTarf1r800F+RlCF6U= k8s.io/client-go v0.23.0/go.mod h1:hrDnpnK1mSr65lHHcUuIZIXDgEbzc7/683c6hyG4jTA= k8s.io/client-go v0.23.2/go.mod h1:k3YbsWg6GWdHF1THHTQP88X9RhB1DWPo3Dq7KfU/D1c= k8s.io/client-go v0.23.5 h1:zUXHmEuqx0RY4+CsnkOn5l0GU+skkRXKGJrhmE2SLd8= k8s.io/client-go v0.23.5/go.mod h1:flkeinTO1CirYgzMPRWxUCnV0G4Fbu2vLhYCObnt/r4= k8s.io/code-generator v0.17.0/go.mod h1:DVmfPQgxQENqDIzVR2ddLXMH34qeszkKSdH/N+s+38s= k8s.io/code-generator v0.22.1/go.mod h1:eV77Y09IopzeXOJzndrDyCI88UBok2h6WxAlBwpxa+o= -k8s.io/code-generator v0.22.2/go.mod h1:eV77Y09IopzeXOJzndrDyCI88UBok2h6WxAlBwpxa+o= k8s.io/code-generator v0.23.0/go.mod h1:vQvOhDXhuzqiVfM/YHp+dmg10WDZCchJVObc9MvowsE= k8s.io/component-base v0.17.0/go.mod h1:rKuRAokNMY2nn2A6LP/MiwpoaMRHpfRnrPaUJJj1Yoc= k8s.io/component-base v0.22.1/go.mod h1:0D+Bl8rrnsPN9v0dyYvkqFfBeAd4u7n77ze+p8CMiPo= -k8s.io/component-base v0.22.2/go.mod h1:5Br2QhI9OTe79p+TzPe9JKNQYvEKbq9rTJDWllunGug= k8s.io/component-base v0.23.0/go.mod h1:DHH5uiFvLC1edCpvcTDV++NKULdYYU6pR9Tt3HIKMKI= k8s.io/component-base v0.23.2 h1:dAYmUhWIBWO762etTjBEEKtYYHi5CoQInSLtK6LM1Zs= k8s.io/component-base v0.23.2/go.mod h1:wS9Z03MO3oJ0RU8bB/dbXTiluGju+SC/F5i660gxB8c= @@ -1560,7 +1543,6 @@ k8s.io/kube-openapi v0.0.0-20211115234752-e816edb12b65/go.mod h1:sX9MT8g7NVZM5lV k8s.io/utils v0.0.0-20191114184206-e782cd3c129f/go.mod h1:sZAwmy6armz5eXlNoLmJcl4F1QuKu7sr+mFQ0byX7Ew= k8s.io/utils v0.0.0-20210707171843-4b05e18ac7d9/go.mod h1:jPW/WVKK9YHAvNhRxK0md/EJ228hCsBRufyofKtW8HA= k8s.io/utils v0.0.0-20210802155522-efc7438f0176/go.mod h1:jPW/WVKK9YHAvNhRxK0md/EJ228hCsBRufyofKtW8HA= -k8s.io/utils v0.0.0-20210819203725-bdf08cb9a70a/go.mod h1:jPW/WVKK9YHAvNhRxK0md/EJ228hCsBRufyofKtW8HA= k8s.io/utils v0.0.0-20210930125809-cb0fa318a74b/go.mod h1:jPW/WVKK9YHAvNhRxK0md/EJ228hCsBRufyofKtW8HA= k8s.io/utils v0.0.0-20211116205334-6203023598ed h1:ck1fRPWPJWsMd8ZRFsWc6mh/zHp5fZ/shhbrgPUxDAE= k8s.io/utils v0.0.0-20211116205334-6203023598ed/go.mod h1:jPW/WVKK9YHAvNhRxK0md/EJ228hCsBRufyofKtW8HA= @@ -1582,10 +1564,8 @@ sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.0.27 h1:KQOkVzXrLNb0E sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.0.27/go.mod h1:tq2nT0Kx7W+/f2JVE+zxYtUhdjuELJkVpNz+x/QN5R4= sigs.k8s.io/apiserver-runtime v1.0.3-0.20210913073608-0663f60bfee2 h1:c6RYHA1wUg9IEsfjnxg0WsPwvDC2Qw2eryXKXgSEF1c= sigs.k8s.io/apiserver-runtime v1.0.3-0.20210913073608-0663f60bfee2/go.mod h1:gvPfh5FX3Wi3kIRpkh7qvY0i/DQl3SDpRtvqMGZE3Vo= -sigs.k8s.io/controller-runtime v0.11.0/go.mod h1:KKwLiTooNGu+JmLZGn9Sl3Gjmfj66eMbCQznLP5zcqA= sigs.k8s.io/controller-runtime v0.11.1 h1:7YIHT2QnHJArj/dk9aUkYhfqfK5cIxPOX5gPECfdZLU= sigs.k8s.io/controller-runtime v0.11.1/go.mod h1:KKwLiTooNGu+JmLZGn9Sl3Gjmfj66eMbCQznLP5zcqA= -sigs.k8s.io/controller-tools v0.7.0/go.mod h1:bpBAo0VcSDDLuWt47evLhMLPxRPxMDInTEH/YbdeMK0= sigs.k8s.io/controller-tools v0.8.0 h1:uUkfTGEwrguqYYfcI2RRGUnC8mYdCFDqfwPKUcNJh1o= sigs.k8s.io/controller-tools v0.8.0/go.mod h1:qE2DXhVOiEq5ijmINcFbqi9GZrrUjzB1TuJU0xa6eoY= sigs.k8s.io/json v0.0.0-20211020170558-c049b76a60c6 h1:fD1pz4yfdADVNfFmcP2aBEtudwUQ1AlLnRBALr33v3s= @@ -1601,11 +1581,9 @@ sigs.k8s.io/kustomize/kustomize/v4 v4.4.1/go.mod h1:qOKJMMz2mBP+vcS7vK+mNz4HBLja sigs.k8s.io/kustomize/kyaml v0.13.0 h1:9c+ETyNfSrVhxvphs+K2dzT3dh5oVPPEqPOE/cUpScY= sigs.k8s.io/kustomize/kyaml v0.13.0/go.mod h1:FTJxEZ86ScK184NpGSAQcfEqee0nul8oLCK30D47m4E= sigs.k8s.io/structured-merge-diff v0.0.0-20190525122527-15d366b2352e/go.mod h1:wWxsB5ozmmv/SG7nM11ayaAW51xMvak/t1r0CSlcokI= -sigs.k8s.io/structured-merge-diff v1.0.1-0.20191108220359-b1b620dd3f06 h1:zD2IemQ4LmOcAumeiyDWXKUI2SO0NYDe3H6QGvPOVgU= sigs.k8s.io/structured-merge-diff v1.0.1-0.20191108220359-b1b620dd3f06/go.mod h1:/ULNhyfzRopfcjskuui0cTITekDduZ7ycKN3oUT9R18= sigs.k8s.io/structured-merge-diff/v4 v4.0.2/go.mod h1:bJZC9H9iH24zzfZ/41RGcq60oK1F7G282QMXDPYydCw= sigs.k8s.io/structured-merge-diff/v4 v4.1.2/go.mod h1:j/nl6xW8vLS49O8YvXW1ocPhZawJtm+Yrr7PPRQ0Vg4= -sigs.k8s.io/structured-merge-diff/v4 v4.2.0/go.mod h1:j/nl6xW8vLS49O8YvXW1ocPhZawJtm+Yrr7PPRQ0Vg4= sigs.k8s.io/structured-merge-diff/v4 v4.2.1 h1:bKCqE9GvQ5tiVHn5rfn1r+yao3aLQEaLzkkmAkf+A6Y= sigs.k8s.io/structured-merge-diff/v4 v4.2.1/go.mod h1:j/nl6xW8vLS49O8YvXW1ocPhZawJtm+Yrr7PPRQ0Vg4= sigs.k8s.io/yaml v1.1.0/go.mod h1:UJmg0vDUVViEyp3mgSv9WPwZCDxu4rQW1olrI1uml+o= diff --git a/keycloak/client.go b/keycloak/client.go index 8666d61..03f9d60 100644 --- a/keycloak/client.go +++ b/keycloak/client.go @@ -453,10 +453,9 @@ func (c Client) PutUser(ctx context.Context, user User) (User, error) { return User{}, fmt.Errorf("failed querying keycloak for user %q: %w", user.Username, err) } - toUpdate := user - toUpdate.ID = *kcUser.ID - return UserFromKeycloakUser(*kcUser).overlay(toUpdate), - c.Client.UpdateUser(ctx, token.AccessToken, c.Realm, toUpdate.KeycloakUser()) + user.ApplyTo(kcUser) + return UserFromKeycloakUser(*kcUser), + c.Client.UpdateUser(ctx, token.AccessToken, c.Realm, *kcUser) } func containsUsername(s []User, a string) bool { diff --git a/keycloak/client_put_user_test.go b/keycloak/client_put_user_test.go index cb604e3..3c9b461 100644 --- a/keycloak/client_put_user_test.go +++ b/keycloak/client_put_user_test.go @@ -18,32 +18,31 @@ func TestPutUser_simple(t *testing.T) { ctrl := gomock.NewController(t) defer ctrl.Finish() + subject := gocloak.User{ + ID: gocloak.StringP("fuuser-id"), + Username: gocloak.StringP("fuuser"), + FirstName: gocloak.StringP("Fuu"), + LastName: gocloak.StringP("Ser"), + Email: gocloak.StringP("fuuser@email.com"), + Attributes: &map[string][]string{ + KeycloakDefaultOrganizationRef: {"foo"}, + }, + } + mKeycloak := NewMockGoCloak(ctrl) c := Client{ Client: mKeycloak, } mockLogin(mKeycloak, c) - mockGetUsers(mKeycloak, c, "fuuser", - []*gocloak.User{ - { - ID: gocloak.StringP("fuuser-id"), - Username: gocloak.StringP("fuuser"), - FirstName: gocloak.StringP("Fuu"), - LastName: gocloak.StringP("Ser"), - Email: gocloak.StringP("fuuser@email.com"), - Attributes: &map[string][]string{ - KeycloakDefaultOrganizationRef: {"foo"}, - }, - }, - }) + mockGetUsers(mKeycloak, c, "fuuser", []*gocloak.User{&subject}) mockUpdateUser(mKeycloak, c, - gocloak.User{ - ID: gocloak.StringP("fuuser-id"), - Username: gocloak.StringP("fuuser"), - Attributes: &map[string][]string{ + func() gocloak.User { + updated := subject + updated.Attributes = &map[string][]string{ KeycloakDefaultOrganizationRef: {"new-foo"}, - }, - }) + } + return updated + }()) u, err := c.PutUser(context.TODO(), User{Username: "fuuser", DefaultOrganizationRef: "new-foo"}) require.NoError(t, err) diff --git a/keycloak/user.go b/keycloak/user.go index b3d8a94..9c54202 100644 --- a/keycloak/user.go +++ b/keycloak/user.go @@ -61,54 +61,30 @@ func (u User) DisplayName() string { return u.FirstName + " " + u.LastName } -// KeycloakUser returns a gocloak.User with attributes set from this user -func (u User) KeycloakUser() gocloak.User { - r := gocloak.User{} +// ApplyTo sets attributes from this user to the given gocloak.User +func (u User) ApplyTo(tu *gocloak.User) { if u.ID != "" { - r.ID = &u.ID + tu.ID = &u.ID } if u.Username != "" { - r.Username = &u.Username + tu.Username = &u.Username } if u.Email != "" { - r.Email = &u.Email + tu.Email = &u.Email } if u.FirstName != "" { - r.FirstName = &u.FirstName + tu.FirstName = &u.FirstName } if u.LastName != "" { - r.LastName = &u.LastName + tu.LastName = &u.LastName } if u.DefaultOrganizationRef != "" { - attr := make(map[string][]string) - attr[KeycloakDefaultOrganizationRef] = []string{u.DefaultOrganizationRef} - r.Attributes = &attr - } - - return r -} - -func (u User) overlay(uo User) User { - r := u - if uo.ID != "" { - r.ID = uo.ID - } - if uo.Username != "" { - r.Username = uo.Username - } - if uo.Email != "" { - r.Email = uo.Email - } - if uo.FirstName != "" { - r.FirstName = uo.FirstName - } - if uo.LastName != "" { - r.LastName = uo.LastName - } + if tu.Attributes == nil { + attr := make(map[string][]string) + tu.Attributes = &attr + } - if uo.DefaultOrganizationRef != "" { - r.DefaultOrganizationRef = uo.DefaultOrganizationRef + (*tu.Attributes)[KeycloakDefaultOrganizationRef] = []string{u.DefaultOrganizationRef} } - return r } diff --git a/keycloak/user_test.go b/keycloak/user_test.go index f89a2bf..48ddb8e 100644 --- a/keycloak/user_test.go +++ b/keycloak/user_test.go @@ -2,6 +2,7 @@ package keycloak import ( "testing" + "time" "github.com/Nerzal/gocloak/v11" "github.com/stretchr/testify/require" @@ -29,58 +30,62 @@ func TestUserFromKeycloakUser(t *testing.T) { })) } -func TestUser_KeycloakUser(t *testing.T) { - require.Equal(t, gocloak.User{}, User{}.KeycloakUser()) +func TestUser_DisplayName(t *testing.T) { + require.Equal(t, "Foo Bar", User{FirstName: "Foo", LastName: "Bar"}.DisplayName()) + require.Equal(t, "Foo", User{FirstName: "Foo"}.DisplayName()) + require.Equal(t, "Bar", User{LastName: "Bar"}.DisplayName()) +} - require.Equal(t, gocloak.User{ - ID: gocloak.StringP("ID"), - Username: gocloak.StringP("Username"), - FirstName: gocloak.StringP("FirstName"), - LastName: gocloak.StringP("LastName"), - Email: gocloak.StringP("Email"), - Attributes: &map[string][]string{ - KeycloakDefaultOrganizationRef: {"DefaultOrganizationRef"}, - }, - }, User{ +func TestUser_ApplyTo(t *testing.T) { + user := User{ ID: "ID", Username: "Username", Email: "Email", FirstName: "FirstName", LastName: "LastName", DefaultOrganizationRef: "DefaultOrganizationRef", - }.KeycloakUser(), - ) -} + } + expected := baseKeycloakUser() + expected.ID = &user.ID + expected.Username = &user.Username + expected.Email = &user.Email + expected.FirstName = &user.FirstName + expected.LastName = &user.LastName + expected.Attributes = &map[string][]string{ + "example.com/dark-mode": {"true"}, + KeycloakDefaultOrganizationRef: {"DefaultOrganizationRef"}, + } + subject := baseKeycloakUser() + user.ApplyTo(&subject) + require.Equal(t, expected, subject, "overwrite all attributes") -func TestUser_DisplayName(t *testing.T) { - require.Equal(t, "Foo Bar", User{FirstName: "Foo", LastName: "Bar"}.DisplayName()) - require.Equal(t, "Foo", User{FirstName: "Foo"}.DisplayName()) - require.Equal(t, "Bar", User{LastName: "Bar"}.DisplayName()) + subject = baseKeycloakUser() + subject.Attributes = nil + user.ApplyTo(&subject) + require.Equal(t, &map[string][]string{ + KeycloakDefaultOrganizationRef: {"DefaultOrganizationRef"}, + }, subject.Attributes, "create .Attributes if nil") + + subject = baseKeycloakUser() + User{}.ApplyTo(&subject) + require.Equal(t, baseKeycloakUser(), subject, "no attributes overridden") } -func TestUser_overlay(t *testing.T) { - base := User{ - ID: "a", - Username: "a", - Email: "a", - FirstName: "a", - LastName: "a", - DefaultOrganizationRef: "a", +func baseKeycloakUser() gocloak.User { + return gocloak.User{ + ID: p("base"), + CreatedTimestamp: p(time.Date(2000, time.January, 2, 3, 3, 3, 0, time.UTC).UnixNano()), + Username: p("base"), + Enabled: p(true), + FirstName: p("base"), + LastName: p("base"), + Email: p("base"), + Attributes: p(map[string][]string{"example.com/dark-mode": {"true"}}), + RequiredActions: p([]string{"reset-credentials"}), + Credentials: p([]gocloak.CredentialRepresentation{{ID: p("cred-id")}}), } - require.Equal(t, base, base.overlay(User{})) - - overlay := User{DefaultOrganizationRef: "b"} - overlayed := base - overlayed.DefaultOrganizationRef = overlay.DefaultOrganizationRef - require.Equal(t, overlayed, base.overlay(overlay)) +} - overlay = User{ - ID: "b", - Username: "b", - Email: "b", - FirstName: "b", - LastName: "b", - DefaultOrganizationRef: "b", - } - require.Equal(t, overlay, base.overlay(overlay)) +func p[T any](a T) *T { + return &a }