Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-2320: Fix opendata-group add CLI command #2405

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

bzar
Copy link
Contributor

@bzar bzar commented Sep 30, 2024

  • Adding users to groups now requires username in context even with ignore_auth

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.86%. Comparing base (fe51042) to head (ee13bf0).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
ckan/ckanext/ckanext-ytp_main/ckanext/ytp/cli.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2405      +/-   ##
==========================================
- Coverage   26.87%   26.86%   -0.01%     
==========================================
  Files          42       42              
  Lines        5921     5922       +1     
  Branches       37       37              
==========================================
  Hits         1591     1591              
- Misses       4330     4331       +1     
Flag Coverage Δ
cdk 92.02% <ø> (ø)
ckan 21.64% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Sep 30, 2024

opendata    Run #5101

Run Properties:  status check passed Passed #5101  •  git commit ff64011751 ℹ️: Merge ee13bf09c5d8ea0fea2cc7cf108f785e8a14aa57 into d6076b85fa249ac941f3d0b1ba48...
Project opendata
Branch Review AV-2320_add-all-users-to-new-groups
Run status status check passed Passed #5101
Run duration 04m 19s
Commit git commit ff64011751 ℹ️: Merge ee13bf09c5d8ea0fea2cc7cf108f785e8a14aa57 into d6076b85fa249ac941f3d0b1ba48...
Committer Teemu Erkkola
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 85
View all changes introduced in this branch ↗︎

@bzar bzar merged commit e71c91c into master Sep 30, 2024
38 of 42 checks passed
@bzar bzar deleted the AV-2320_add-all-users-to-new-groups branch September 30, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants