Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SaturationAlgorithm::addInputSOSClause is currently skipping forwardSimplify #562

Open
quickbeam123 opened this issue May 22, 2024 · 0 comments

Comments

@quickbeam123
Copy link
Collaborator

Filling up the active container at the start under SOS is not doing full clause inter-reductions even if enabled.

We might want to do it for consistency, efficiency, and stronger invariants (e.g., "can't have two alpha-equivalent clauses in the forward subsumption index when FSub enabled, ...)

However, this is not a one-line fix, because forwardSimplify normally puts clause replacements into _newClauses from which travel to _unprocessed from which they normally go to _passive. So this long clause dispatch would need to be duplicated for the sake of addInputSOSClause or parametrized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant