Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policy "applyto" options missing #947

Closed
jimmybigcommerce opened this issue Oct 30, 2023 · 2 comments · Fixed by #948
Closed

Policy "applyto" options missing #947

jimmybigcommerce opened this issue Oct 30, 2023 · 2 comments · Fixed by #948
Labels
skip-changelog

Comments

@jimmybigcommerce
Copy link
Contributor

puppet-rabbitmq/REFERENCE.md

Lines 1776 to 1782 in ba728f5

##### `applyto`
Valid values: `all`, `exchanges`, `queues`
policy apply to
Default value: `all`

Currently this module only support the following options for the policy applyto option:

##### `applyto`

Valid values: `all`, `exchanges`, `queues`

However, RabbitMQ itself supports:

all, exchanges, queues, classic_queues, quorum_queues, streams

It would be great if this module supported these also
@wyardley wyardley added the enhancement New feature or request label Oct 30, 2023
wyardley added a commit to wyardley/puppet-rabbitmq that referenced this issue Oct 30, 2023
@wyardley
Add additional applyto options for policies
bba1a8b 
Add additional `applyto` options for the `rabbimq_policy` resource type.

Fixes voxpupuli#947
@wyardley wyardley mentioned this issue Oct 30, 2023
Merged
wyardley added a commit to wyardley/puppet-rabbitmq that referenced this issue Oct 30, 2023
@wyardley
Add additional applyto options for policies
19af788 
Add additional `applyto` options for the `rabbimq_policy` resource type.

Fixes voxpupuli#947
@wyardley
Copy link
Contributor

I've taken a pass at this in #948

@bastelfreak bastelfreak added skip-changelog and removed enhancement New feature or request labels Oct 30, 2023
@jimmybigcommerce
Copy link
Contributor Author

Amazing @wyardley - greatly appreciated!

wyardley added a commit that referenced this issue Nov 14, 2024
@wyardley
Add additional applyto options for policies
6dc9ceb 
Add additional `applyto` options for the `rabbimq_policy` resource type.

Fixes #947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add additional applyto options for policies wyardley/puppet-rabbitmq
3 participants
@bastelfreak @wyardley @jimmybigcommerce