Required packages vary in different Debian releases

[iay]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 6.15.0
• Ruby: n/a
• Distribution: Debian 10
• Module version: 3.0.0 (but looking at the code, I think 4.0.0 too; I can't run that just yet because I have an Ubuntu 14.04 system under management still.)

How to reproduce (e.g Puppet code you use)

include nrpe

What are you seeing

On Debian 10 (Buster):

Notice: /Stage[main]/Nrpe::Install/Package[nagios-plugins]/ensure: created (corrective)

What behaviour did you expect instead

I didn't expect to see anything.

Output log

Any additional information you'd like to impart

This seems to be because puppet-nrpe has the following parameters for all "Debian" releases:

  case fact('os.family') {
    'Debian':  {
      $libdir           = '/usr/lib/nagios/plugins'
      $nrpe_user        = 'nagios'
      $nrpe_group       = 'nagios'
      $nrpe_pid_file    = '/var/run/nagios/nrpe.pid'
      $nrpe_config      = '/etc/nagios/nrpe.cfg'
      $nrpe_ssl_dir     = '/etc/nagios/nrpe-ssl'
      $nrpe_include_dir = '/etc/nagios/nrpe.d'
      $nrpe_service     = 'nagios-nrpe-server'
      $nrpe_packages    = [
        'nagios-nrpe-server',
        'nagios-plugins',
      ]
    }

I suspect this was entirely correct under Debian 8 or at least some version prior to Debian 9.

Under Debian 9, nagios-nrpe-server depends on a new package monitoring-plugins, and nagios-plugins is a transitional metapackage which just brings that in, so there is no notification.

Under Debian 10, nagios-plugins no longer exists, hence the notice. nagios-nrpe-server still depends on monitoring-plugins, however, so everything ends up working despite the message.

[couloum]

For information, this issue also happen on Ubuntu 20.04 (and probably later versions).