Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cni-plugins, crictl & etcd cannot be updated #95

Open
olavst-spk opened this issue May 29, 2024 · 1 comment · May be fixed by #96
Open

cni-plugins, crictl & etcd cannot be updated #95

olavst-spk opened this issue May 29, 2024 · 1 comment · May be fixed by #96

Comments

@olavst-spk
Copy link
Contributor

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 7.30.0
  • Ruby: 2.7.8
  • Distribution: RHEL9
  • Module version: 2.0.1

How to reproduce

Install a cluster using the default parameters.

Then try to update cni-plugins, crictl or etcd by changing one of these version parameters (for example through hiera):

  • k8s::install::cni_plugins::version
  • k8s::install::crictl::version
  • k8s::etcd_version

What are you seeing

cni-plugins, crictl & etcd stay on the same version.

What behaviour did you expect instead

cni-plugins, crictl & etcd should be updated to the specified versions.

Output log

Puppet reports no changes since the last run.

Any additional information you'd like to impart

I think the problem is that these components are installed using the archive resource with creates set. Puppet does not download the new version because the files specified in creates already exist.

@ananace
Copy link
Member

ananace commented May 29, 2024

Should probably be changed to a similar system to the main k8s binaries - i.e. /opt/k8s-cni / /opt/k8s-crictl / /opt/k8s-etcd and symlinks.

olavst-spk added a commit to StatensPensjonskasse/puppet-k8s that referenced this issue May 31, 2024
Makes the installation of cni_plugins, crictl & etcd similar to the way
the main k8s binaries are installed. The archives are unpacked to folders
in /opt and symlinked to /usr/local/bin . The target folder is unique
per version, making it possible to update these components.

Fixes voxpupuli#95.
olavst-spk added a commit to StatensPensjonskasse/puppet-k8s that referenced this issue May 31, 2024
Makes the installation of cni_plugins, crictl & etcd similar to the way
the main k8s binaries are installed. The archives are unpacked to folders
in /opt and symlinked to /usr/local/bin . The target folder is unique
per version, making it possible to update these components.

Fixes voxpupuli#95.
olavst-spk added a commit to StatensPensjonskasse/puppet-k8s that referenced this issue May 31, 2024
Makes the installation of cni_plugins, crictl & etcd similar to the way
the main k8s binaries are installed. The archives are unpacked to folders
in /opt and symlinked to /usr/local/bin . The target folder is unique
per version, making it possible to update these components.

Fixes voxpupuli#95.
olavst-spk added a commit to StatensPensjonskasse/puppet-k8s that referenced this issue Jun 3, 2024
Makes the installation of cni_plugins, crictl & etcd similar to the way
the main k8s binaries are installed. The archives are unpacked to folders
in /opt and symlinked to /usr/local/bin . The target folder is unique
per version, making it possible to update these components.

Fixes voxpupuli#95.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants