Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EL8 & EL9 support and claim compatibility #553

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

dadez73
Copy link

@dadez73 dadez73 commented Oct 8, 2024

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@TheMeier
Copy link

TheMeier commented Oct 8, 2024

Please regenerate REFERENCE.md as described in https://voxpupuli.org/docs/how_to_run_tests/#referencemd-update

manifests/init.pp Outdated Show resolved Hide resolved
@TheMeier
Copy link

TheMeier commented Oct 8, 2024

@dadez73 I took the liberty and regenerated the REFERENCE.md in dadez73@ab9299e using the method described in the docs earlier.

That all would need to be squashed in a single commit IMHO. On top of that I would like to ask you to separate out the metadata.json updates for RHEL/CentOS into a separate MR.

Apart from that we should also have yet another separate MR that drops CentOS 7 and RHEL 7 from the metadata.

You are somewhat unlucky here, I guess this module just needs some TLC in general, tests have been failing for some time already. Maybe we should just clean up all the MRs that are still open since back then :/

@dadez73
Copy link
Author

dadez73 commented Oct 9, 2024

hi @TheMeier, so, i will close this PR and create new ones. RH , Centos7 and one for the Test.

@dadez73
Copy link
Author

dadez73 commented Oct 14, 2024

@TheMeier when i regenerated the REFERENCE.md with "bundle exec rake strings:generate:reference" the test fail anyway saying that is outdated. There is something im missing?

@TheMeier
Copy link

@dadez73 I found the chop/chomp issues myself on the weekend It would be nice if we could #555 merged first, I don't think we need all those regex changes you proposed. Also 555 actually has all tests ok now.

@dadez73
Copy link
Author

dadez73 commented Oct 14, 2024

@TheMeier I saw them working correctly, perhabs is because I have ruby 3.3.3 locally and they are failing.
Maybe when we add support for puppet8 they will popup again.
But for the reference file i have no idea why it says is outdated...

@TheMeier
Copy link

I have spent quite some time on the tests on the weekend. The default provider for debian is incorrectly set to crm in the tests. Also we discovered that the cleanup in https://github.com/voxpupuli/puppet-corosync/blob/master/spec/spec_helper_acceptance.rb#L41 is flaky :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants