-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EL8 & EL9 support and claim compatibility #553
base: master
Are you sure you want to change the base?
Conversation
Puppet::Type::Cs_clone::ProviderPcs when changing clone id each instance calls cibadmin with the correct parameters
Please regenerate REFERENCE.md as described in https://voxpupuli.org/docs/how_to_run_tests/#referencemd-update |
@dadez73 I took the liberty and regenerated the REFERENCE.md in dadez73@ab9299e using the method described in the docs earlier. That all would need to be squashed in a single commit IMHO. On top of that I would like to ask you to separate out the metadata.json updates for RHEL/CentOS into a separate MR. Apart from that we should also have yet another separate MR that drops CentOS 7 and RHEL 7 from the metadata. You are somewhat unlucky here, I guess this module just needs some TLC in general, tests have been failing for some time already. Maybe we should just clean up all the MRs that are still open since back then :/ |
hi @TheMeier, so, i will close this PR and create new ones. RH , Centos7 and one for the Test. |
@TheMeier when i regenerated the REFERENCE.md with "bundle exec rake strings:generate:reference" the test fail anyway saying that is outdated. There is something im missing? |
@TheMeier I saw them working correctly, perhabs is because I have ruby 3.3.3 locally and they are failing. |
I have spent quite some time on the tests on the weekend. The default provider for debian is incorrectly set to |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues