Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set crm as default provider for ubuntu #538

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dploeger
Copy link

Pull Request (PR) description

Sets CRM as the default provider for Ubuntu machines.

This Pull Request (PR) fixes the following issues

none (can create one if required)

I couldn't test the unit tests because of #536 It works in our environment though.

@zilchms
Copy link
Contributor

zilchms commented Feb 20, 2024

Hey @dploeger,
with #520 I think you can rebase this PR and the CI should hopefully pass. On another note: I think the change you want to see should be achieved differently. Namely: change the hieradata entry under data/os/Ubuntu.yaml (there should be crm OSes where you can basically fully copy the yaml from)
This might cause a breaking CI. If it does I think you additionally have to modify spec_helper_acceptance.rb and spec_helper_corosync.rb; on that I am not sure though

@dploeger dploeger force-pushed the feature/crm-default-ubuntu branch from 8a5f888 to 9fe5e44 Compare February 21, 2024 08:59
@dploeger
Copy link
Author

@zilchms Rebased this.

How can you change the defaultfor parameter of the provider using the hieradata?

@dploeger
Copy link
Author

@zilchms After rebasing, some checks still fail and it doesn't seem it is because of my changes

@dploeger dploeger mentioned this pull request Feb 28, 2024
@dploeger
Copy link
Author

dploeger commented Aug 5, 2024

@zilchms @bastelfreak Can somebody take a look at this please?

@bastelfreak bastelfreak closed this Aug 5, 2024
@bastelfreak bastelfreak reopened this Aug 5, 2024
@bastelfreak
Copy link
Member

@dploeger can you please take a look at the failing test?

@dploeger
Copy link
Author

dploeger commented Aug 5, 2024

@bastelfreak Hm. I can't recreate the failure locally and the other test suites were fine. Can you restart the failing test maybe?

@bastelfreak
Copy link
Member

I restarted it, but the error stays

@dploeger dploeger force-pushed the feature/crm-default-ubuntu branch from 77c6a42 to e55b686 Compare August 5, 2024 12:41
@dploeger
Copy link
Author

dploeger commented Aug 5, 2024

@bastelfreak I'm a bit baffled by this. If I read the code right, it expects an execution with a specific value but the actual execution misses a bracket. I don't think this is because of my code change, but I can't see why this happens at all. Do you have any idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants