Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conteiner bounds overflow #1

Open
Shpakovich opened this issue Apr 22, 2022 · 0 comments
Open

Conteiner bounds overflow #1

Shpakovich opened this issue Apr 22, 2022 · 0 comments
Assignees

Comments

@Shpakovich
Copy link

Shpakovich commented Apr 22, 2022

If you create a tiler with parameters where toCount is greater than colCount and rowCount:

{ // draw area params for tiler
     "fromCount": 30,
      "toCount": 40,
      "colCount": 7,
      "rowCount": 5,
      "margin": 4,
      "forceAspectRatio": 1.7777777777777777
}

In this case, the overflow check will not work and tiler compose() will return a grid with video slots not included in the area, instead of cutting off extra videos:

{ // returned slot example
    "height": 170,
    "width": 303,
    "top": 1017,
    "left": 1233,
    "stream": {
        "id": "local",
        "objectFit": "cover",
        "kind": "",
        "title": {
            "label": "Denis Shmakov",
            "padding": 2,
            "margin": 8,
            "position": "bottom right"
        },
        "area": 1,
        "muted": false
    }
}

for example 39-s video element, where top + height > area size. Screenshot of what it looks:

Снимок экрана 2022-04-22 в 12 09 10

I am attaching logs with what was sent and returned from tiler compose()
compose_log_input.log
compose_log_output.log

@irbisadm irbisadm changed the title Переполнение сетки tiler Conteiner bounds overflow Apr 22, 2022
@irbisadm irbisadm self-assigned this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants