[svlogd] prevent deletion of the processing file #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svlogd expects time to be correct, but sometimes this is not the case. If time information is inaccurate, it is possible for svlogd to delete the file it is about to process. When this happens, svlogd will enter an infinite busy loop trying to process a file that no longer exists. This patch prevents that case from happening by excluding processing file from consideration when removing old log files.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
svlogd expects time to be correct, but sometimes this is not the case. If time information is inaccurate, it is possible for svlogd to delete the file it is about to process. When this happens, svlogd will enter an infinite busy loop trying to process a file that no longer exists. This patch prevents that case from happening by excluding processing file from consideration when removing old log files.