Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playstation store: monthly games and games catalog #225

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

4n4n4s
Copy link
Contributor

@4n4n4s 4n4n4s commented Sep 24, 2023

#165 updated the PR and added option to also claim catalog games.

@OJ7 @Barokai maybe you can both check it. Note there are some changes in the properties it's PS_ not PSP_

@Barokai
Copy link

Barokai commented Sep 25, 2023

Looking good to me on a first (quick) look.
Some console.logs and comments could be cleaned up or formatted, but the logic is fine.
Will have more time to check later this week if needed.

Copy link

sonarcloud bot commented Nov 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

@Barokai Barokai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me, well commented too :)

@viperdriver2000
Copy link

could it be that it is no longer up to date because config.js no longer exists?

@vogler
Copy link
Owner

vogler commented Dec 28, 2023

@viperdriver2000 Yes, sorry, I moved some files in 6467679.
I'll take a look at the PRs today and then we can update and merge.

@4n4n4s
Copy link
Contributor Author

4n4n4s commented Feb 12, 2024

@vogler have not used it for some time so you really need to retest it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants