Refactor accounts #331
Open
Refactor accounts #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
marcvelmer
force-pushed
the
f/accounts_refactor
branch
from
0962239 to
20261c2
Compare
elboletaire
requested changes
Feb 13, 2024
There was a problem hiding this comment.
Just a minor type change suggestion/fix. Other than that, this refactor makes total sense, and the code looks good. Also done some tests updating ui-components from my side, and all looking good there too: vocdoni/ui-components#144 (actions are not passing due to the fileutil issue, for which I may open an issue sooner or later)
| promAccountData: Promise<{ tx: Uint8Array; metadata: string; message: string }> | ||
| ): Promise<AccountData> { | ||
| const accountTx = promAccountData.then((setAccountInfoTx) => | ||
| promAccount: Promise<{ tx: Uint8Array; metadata: string; message: string }> |
There was a problem hiding this comment.
Can this be defined as a type and exported? Actually, the docblock doesn't seem to match with this definition (docblock does not define message: string).
edit: didn't realize it's a private function, so there's no need to export it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.