Address findings from the linters configured in golangci-lint.

[tenthirtyam]

Code of Conduct

• I have read and agree to the Code of Conduct.
• Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
• Do not leave "+1" or other comments that do not add relevant information or questions.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Terraform

latest

Terraform Provider

latest

Description

After merging #435 to update the golangci-lint workflow the action currently does not complete successfully as there is some technical debt that needs to be addressed based on the findings by a few of the linters.

You can expand the results here or run golangci-lint run in the project root locally to observe the findings. These include:

• integer overflow conversion int
• const example is unused
• import example is not allowed from list 'Main'
• naked return in function
• append only allowed to cuddle with appended value
• only one cuddle assignment allowed before if statement
• expressions should not be cuddled with blocks
• if statements should only be cuddled with assignments

Affected Resources or Data Sources

Not applicable.

Terraform Configuration

Not applicable.

Debug Output

Not applicable.

Panic Output

Not applicable.

Expected Behavior

The GitHub Action for the run of golangci-lint run should find no error

Actual Behavior

You can expand the results here or run golangci-lint run in the project root locally to observe the findings. These include:

• integer overflow conversion int
• const example is unused
• import example is not allowed from list 'Main'
• naked return in function
• append only allowed to cuddle with appended value
• only one cuddle assignment allowed before if statement
• expressions should not be cuddled with blocks
• if statements should only be cuddled with assignments

Steps to Reproduce

Run golangci-lint run in the root of the project.

Environment Details

No response

Screenshots

No response

References

GitHub Action Run Results