free pPool->considered

vmware · May 2, 2022 · fc25f2a · fc25f2a
1 parent b4b6be4
commit fc25f2a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/client/goal.c b/client/goal.c
@@ -959,7 +959,11 @@ TDNFSolvAddMinVersions(
     map_setall(pPool->considered);
     map_subtract(pPool->considered, pMapMinVersions);
 cleanup:
-    TDNFFreeMemory(pMapMinVersions);
+    if(pMapMinVersions)
+    {
+        map_free(pMapMinVersions);
+        TDNFFreeMemory(pMapMinVersions);
+    }
     TDNF_SAFE_FREE_MEMORY(pszTmp);
     TDNF_SAFE_FREE_STRINGARRAY(ppszTokens);
     return dwError;

diff --git a/solv/tdnfpool.c b/solv/tdnfpool.c
@@ -48,6 +48,12 @@ SolvFreeSack(
         Pool* pPool = pSack->pPool;
         if(pPool)
         {
+            if (pPool->considered)
+            {
+                /* shouldn't this be owned by pPool? */
+                map_free(pPool->considered);
+                TDNF_SAFE_FREE_MEMORY(pPool->considered);
+            }
             pool_free(pPool);
         }
         TDNF_SAFE_FREE_MEMORY(pSack->pszCacheDir);