use build tooling for building capabilities component #4307

yharish991 · 2023-01-30T16:30:41Z

What this PR does / why we need it

This pr uses build tooling for building capabilities component

Which issue(s) this PR fixes

Describe testing done for PR

Ran make docker-build-all -f build-tooling.mk from the project's root directory and verified that the capabilities component is built.

Release note

Additional information

Special notes for your reviewer

github-actions · 2023-02-15T03:42:30Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4307/20230215034227/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

codecov · 2023-02-15T04:45:49Z

Codecov Report

Merging #4307 (9ee961e) into feature/runtime-core (e815dca) will decrease coverage by 0.88%.
The diff coverage is n/a.

❗ Current head 9ee961e differs from pull request most recent head 5abfcaa. Consider uploading reports for the commit 5abfcaa to get more accurate results

@@                   Coverage Diff                    @@
##           feature/runtime-core    #4307      +/-   ##
========================================================
- Coverage                 49.60%   48.72%   -0.88%     
========================================================
  Files                       452      482      +30     
  Lines                     45044    47175    +2131     
========================================================
+ Hits                      22344    22987     +643     
- Misses                    20577    22015    +1438     
- Partials                   2123     2173      +50

Impacted Files	Coverage Δ
capabilities/client/pkg/discovery/fake.go	`100.00% <ø> (ø)`
...ons/controllers/packageinstallstatus_controller.go	`77.99% <0.00%> (-2.32%)`	⬇️
...cluster/delete_machinehealthcheck_control_plane.go	`16.66% <0.00%> (ø)`
cmd/cli/plugin/cluster/get_node_pools.go	`10.52% <0.00%> (ø)`
cmd/cli/plugin/cluster/scale.go	`17.85% <0.00%> (ø)`
.../cli/plugin/cluster/get_machinehealthcheck_node.go	`9.30% <0.00%> (ø)`
cmd/cli/plugin/cluster/list.go	`11.36% <0.00%> (ø)`
cmd/cli/plugin/cluster/get_machinehealthcheck.go	`11.42% <0.00%> (ø)`
cmd/cli/plugin/cluster/delete_node_pool.go	`16.66% <0.00%> (ø)`
cmd/cli/plugin/cluster/credentials_update.go	`8.73% <0.00%> (ø)`
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2023-02-17T03:10:59Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4307/20230217031057/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2023-02-17T19:42:28Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4307/20230217194227/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2023-02-17T20:11:42Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4307/20230217201140/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

yharish991 · 2023-02-20T05:32:20Z

CAPD integration tests have been consistently failing for some reason, it looks unrelated to the changes in this pr

danniel1205 · 2023-02-22T20:30:18Z

Dockerfile

@@ -0,0 +1,75 @@
+# Copyright 2023 VMware, Inc. All Rights Reserved.


Suggestion: Purely from user experience perspective, is it possible to rename this Dockerfile to be something else from which people understand this Dockerfile cannot be directly used by docker build under T-F root. (Or we could add some inline comments?)

The reason why I am raising this is because I got confused at the beginning until I looked into the dockerfile content.

docker-build make target in t-f Makefile calls the docker-build target command in each component's Makefile, but I can add a comment to provide more clarity

added the comment

danniel1205 · 2023-02-22T20:45:45Z

build-tooling.mk

@@ -0,0 +1,297 @@
+.DEFAULT_GOAL := help


question: when we make changes in https://github.com/vmware-tanzu/build-tooling-for-integrations/tree/main/templates, or when user makes changes against this file in T-F by adding more components, what we can do to make things consistent ?

it's up to the consumer(t-f) on when they want to consume the new release from https://github.com/vmware-tanzu/build-tooling-for-integrations, but when they update the Makefile in t-f it is their responsibility to update the components var, but this will change later when the design gets approved and implemented(we will have a config file to maintain components)

github-actions · 2023-02-23T01:40:19Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4307/20230223014017/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2023-02-23T16:00:23Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4307/20230223160021/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

.github/workflows/build-using-buildtooling-for-pullrequests.yaml

rajathagasthya · 2023-02-22T22:32:57Z

build-tooling.mk

+IMG_VERSION_OVERRIDE ?= $(IMG_DEFAULT_TAG)
+GOPROXY ?= "https://proxy.golang.org,direct"
+PLATFORM=local
+COMPONENTS ?= capabilities/client capabilities/controller.capabilities-controller-manager.capabilities


Could you add a comment about what this line means and how COMPONENTS is supposed to be used?

added a comment that provides link to the documentation

github-actions · 2023-02-24T15:09:35Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4307/20230224150934/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

yharish991 requested review from a team as code owners January 30, 2023 16:30

vmwclabot added the cla-not-required label Jan 30, 2023

yharish991 marked this pull request as draft January 30, 2023 16:30

yharish991 force-pushed the useBuildToolingForCapabilities branch 8 times, most recently from 8cc0471 to 0f72d1d Compare February 14, 2023 23:57

yharish991 force-pushed the useBuildToolingForCapabilities branch from 781f052 to dcba2d1 Compare February 17, 2023 02:59

yharish991 force-pushed the useBuildToolingForCapabilities branch from dcba2d1 to 377abdf Compare February 17, 2023 19:31

yharish991 force-pushed the useBuildToolingForCapabilities branch from 377abdf to e9348e9 Compare February 17, 2023 20:02

yharish991 requested a review from codegold79 February 20, 2023 05:30

yharish991 assigned rajathagasthya and unassigned rajathagasthya Feb 20, 2023

yharish991 requested review from rajathagasthya and jmoroski February 20, 2023 05:30

yharish991 marked this pull request as ready for review February 20, 2023 05:31

yharish991 requested review from a team as code owners February 20, 2023 05:31

yharish991 changed the title ~~[WIP] use build tooling for building capabilities image~~ use build tooling for building capabilities image Feb 21, 2023

codegold79 approved these changes Feb 22, 2023

View reviewed changes

danniel1205 reviewed Feb 22, 2023

View reviewed changes

yharish991 changed the title ~~use build tooling for building capabilities image~~ use build tooling for building capabilities component Feb 22, 2023

danniel1205 reviewed Feb 22, 2023

View reviewed changes

yharish991 force-pushed the useBuildToolingForCapabilities branch from e9348e9 to d5385d2 Compare February 23, 2023 01:30

rajathagasthya reviewed Feb 23, 2023

View reviewed changes

yharish991 changed the base branch from main to feature/runtime-core February 24, 2023 17:45

rajathagasthya approved these changes Feb 24, 2023

View reviewed changes

rajathagasthya added the ok-to-merge PRs should be labelled with this before merging label Feb 24, 2023

use build tooling for building capabilities component

5abfcaa

yharish991 force-pushed the useBuildToolingForCapabilities branch from 9ee961e to 5abfcaa Compare February 26, 2023 15:23

yharish991 merged commit 5de127a into vmware-tanzu:feature/runtime-core Feb 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use build tooling for building capabilities component #4307

use build tooling for building capabilities component #4307

yharish991 commented Jan 30, 2023 •

edited

Loading

github-actions bot commented Feb 15, 2023

codecov bot commented Feb 15, 2023 •

edited

Loading

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

yharish991 commented Feb 20, 2023 •

edited

Loading

danniel1205 Feb 22, 2023

yharish991 Feb 22, 2023

yharish991 Feb 23, 2023

danniel1205 Feb 22, 2023

yharish991 Feb 22, 2023 •

edited

Loading

github-actions bot commented Feb 23, 2023

github-actions bot commented Feb 23, 2023

rajathagasthya Feb 22, 2023

yharish991 Feb 24, 2023

github-actions bot commented Feb 24, 2023

		@@ -0,0 +1,75 @@
		# Copyright 2023 VMware, Inc. All Rights Reserved.

use build tooling for building capabilities component #4307

use build tooling for building capabilities component #4307

Conversation

yharish991 commented Jan 30, 2023 • edited Loading

What this PR does / why we need it

Which issue(s) this PR fixes

Describe testing done for PR

Release note

Additional information

Special notes for your reviewer

github-actions bot commented Feb 15, 2023

codecov bot commented Feb 15, 2023 • edited Loading

Codecov Report

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

yharish991 commented Feb 20, 2023 • edited Loading

danniel1205 Feb 22, 2023

Choose a reason for hiding this comment

yharish991 Feb 22, 2023

Choose a reason for hiding this comment

yharish991 Feb 23, 2023

Choose a reason for hiding this comment

danniel1205 Feb 22, 2023

Choose a reason for hiding this comment

yharish991 Feb 22, 2023 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Feb 23, 2023

github-actions bot commented Feb 23, 2023

rajathagasthya Feb 22, 2023

Choose a reason for hiding this comment

yharish991 Feb 24, 2023

Choose a reason for hiding this comment

github-actions bot commented Feb 24, 2023

yharish991 commented Jan 30, 2023 •

edited

Loading

codecov bot commented Feb 15, 2023 •

edited

Loading

yharish991 commented Feb 20, 2023 •

edited

Loading

yharish991 Feb 22, 2023 •

edited

Loading