Fixing unexpected short fan activation when on level "0" for new gen Thinkpads #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be nice to add that blurb from the documentation (or a link to that part of the document) as a comment with that code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #114, on newer Thinkpads (at least AMD Thinkpad E14 gen 2 and gen 6 affected) when the fan speed is set to "level 0", the fan spins up up very briefly around every 120 seconds.
In fact, the kernel's thinkpad-acpi documentation states that :
As such, to prevent the watchdog from resetting the fan to "automatic", Thinkfan resets the fan speed every 120 second to the current level.
However at low temperature, and if the speed is set to "level 0", rewriting 'level 0' to /proc/acpi/ibm/fan causes the fan to spin up for half a second or so.
This pull request proposes an alternative to resetting the fan speed in order to prevent the watchdog reset (as per @pennae proposition).
Fixes #114