Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Calendar Button not working #579

Open
geva-kf-admin opened this issue Jan 18, 2023 · 13 comments
Open

New Calendar Button not working #579

geva-kf-admin opened this issue Jan 18, 2023 · 13 comments

Comments

@geva-kf-admin
Copy link

geva-kf-admin commented Jan 18, 2023

With the new(?) Version from Proton Mail Client I see on the right panel a new Button for the Calendar, but it doesn't work with ElectronMail. In the Browser it works fine and open the Calendar.

Bild 002

Following errors in the logfile:

[2023-01-18 19:16:36.360] [error] src\electron-main\web-contents.ts {"level":3,"message":"Access to fetch at 'https:///auth/info' from origin 'webclient://calendar.proton.me' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.","line":0,"sourceId":"webclient://calendar.proton.me/"}
[2023-01-18 19:16:36.375] [error] src\web\browser-window\app_accounts\account-view.component.ts AccountViewComponent webview event {"type":"console-message","level":3,"message":"Access to fetch at 'https:///auth/info' from origin 'webclient://calendar.proton.me' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.","line":0,"sourceId":"webclient://calendar.proton.me/"}

@geva-kf-admin geva-kf-admin changed the title New Calendar Icon not working New Calendar Button not working Jan 18, 2023
@vladimiry
Copy link
Owner

vladimiry commented Jan 18, 2023

Thanks for the report. I didn't notice this new feature before publishing the 5.1.3 release and so didn't try it in action.

@vladimiry
Copy link
Owner

vladimiry commented Jan 19, 2023

There is no easy fix as they use iframe for embedding the entire calendar web app on the side panel vs mounting calendar-related components into the same page/DOM.

@geva-kf-admin
Copy link
Author

Thanks for the analyze. Maybe in future Releases will it work 👍 👍 👍

@vladimiry vladimiry pinned this issue Feb 22, 2023
@rauldipeas
Copy link

Any news on this issue?

@vladimiry
Copy link
Owner

I tried some ideas in wip-drawer-iframe branch, but it remains incomplete. I don't know when I try again. Fighting iframes is a sort of boring thing to do. No need to ask for news, you will see some if there are any.

@GoldenGlimpse
Copy link

Is this the same reason why Proton Drive doesn't work?

@vladimiry
Copy link
Owner

Is this the same reason why Proton Drive doesn't work?

It's not. Drive supposed to work, for long time. Try relogin if it doesn't.

@GoldenGlimpse
Copy link

GoldenGlimpse commented Jun 13, 2023

It's not. Drive supposed to work, for long time. Try relogin if it doesn't.

Drive stopped working for me since version v5.1.7 i believe. I hoped it would work after an update which i just did, but still no luck.
I get stuck on the page !Something went wrong and have to relogin to solve it.

edit: seems to be solved now somehow.

@PegHorse
Copy link

The bug occur again with same error message in the log.

@vladimiry
Copy link
Owner

vladimiry commented May 21, 2024

It was not fixed, so of course it occurs again. I mean the calendar button issue.

@PegHorse
Copy link

Did you drop that bug or will you fix it ?

@vladimiry
Copy link
Owner

I mean the calendar button issue.

Did you drop that bug or will you fix it ?

This issue remains open, so there is a chance for it to get fixed one day. But I'm not ready for another attempt, iframe stuff is a mess to work with. There is still a hope that Proton converts iframe use for calendar embedding to a regular single page application approach, how it's supposed to be these days, so then the issue gets self-resolved.

@vladimiry
Copy link
Owner

To reduce confusion, the next release comes with cut out Calendar icon. Already implemented in the wip branch (the test build shared in #694 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants