spellcheck: show disabled "no languages" menu item if list is empty

vladimiry · Jun 2, 2019 · 20e479f · 20e479f
1 parent 9e59686
commit 20e479f
Showing 1 changed file with 24 additions and 16 deletions.
diff --git a/src/electron-main/spell-check/menu.ts b/src/electron-main/spell-check/menu.ts
@@ -42,22 +42,30 @@ export function buildSpellCheckSettingsMenuItems(
         },
     ];
 
-    if (checkSpelling && detectedLocales.length) {
-        menuItems.push({
-            label: "Languages",
-            submenu: detectedLocales.map((detectedLocale) => {
-                return {
-                    label: detectedLocale,
-                    type: "radio",
-                    enabled: checkSpelling,
-                    checked: detectedLocale === currentLocale,
-                    click() {
-                        onChangeLocale(detectedLocale);
-                    },
-                } as const;
-            }),
-        });
+    if (!checkSpelling) {
+        return menuItems;
     }
 
-    return menuItems;
+    return [
+        ...menuItems,
+        detectedLocales.length
+            ? {
+                label: "Languages",
+                submenu: detectedLocales.map((detectedLocale) => {
+                    return {
+                        label: detectedLocale,
+                        type: "radio",
+                        enabled: checkSpelling,
+                        checked: detectedLocale === currentLocale,
+                        click() {
+                            onChangeLocale(detectedLocale);
+                        },
+                    } as const;
+                }),
+            }
+            : {
+                label: "(No Languages)",
+                enabled: false,
+            },
+    ];
 }