Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint GitHub workflow #580

Merged
merged 6 commits into from
Dec 9, 2024
Merged

Fix lint GitHub workflow #580

merged 6 commits into from
Dec 9, 2024

Conversation

johnnyomair
Copy link
Collaborator

@johnnyomair johnnyomair commented Dec 2, 2024

The lint GitHub workflow had multiple issues:

  1. The lint:ci scripts weren't used
  2. The lint for generated files in the Admin was calling the API Generator 😂
  3. The Admin Generator wasn't working due to missing the config file

@johnnyomair johnnyomair self-assigned this Dec 2, 2024
admin/package.json Outdated Show resolved Hide resolved
@johnnyomair johnnyomair marked this pull request as ready for review December 3, 2024 15:09
@johnnyomair johnnyomair mentioned this pull request Dec 3, 2024
package.json Outdated Show resolved Hide resolved
dkarnutsch
dkarnutsch previously approved these changes Dec 3, 2024
dkarnutsch
dkarnutsch previously approved these changes Dec 4, 2024
dkarnutsch
dkarnutsch previously approved these changes Dec 9, 2024
site/package.json Outdated Show resolved Hide resolved
@johnnyomair johnnyomair merged commit c110ff2 into main Dec 9, 2024
3 checks passed
@johnnyomair johnnyomair deleted the fix-lint-workflow branch December 9, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants