Add Knip #560
Merged
Add Knip #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelblum
commented
Nov 25, 2024
|
i would like to discuss this tomorrow |
auto-assign
bot
requested review from
dkarnutsch,
fraxachun,
johnnyomair,
nsams and
thomasdax98
fraxachun
reviewed
Nov 26, 2024
johnnyomair
reviewed
Nov 27, 2024
manuelblum
force-pushed
the
chore/add-knip
branch
from
6860019 to
a7afb70
Compare
manuelblum
force-pushed
the
chore/add-knip
branch
from
a7afb70 to
87e1349
Compare
fraxachun
previously approved these changes
Dec 2, 2024
thomasdax98
reviewed
Dec 2, 2024
johnnyomair
reviewed
Dec 2, 2024
johnnyomair
added a commit
to vivid-planet/comet
that referenced
this pull request
Dec 9, 2024
#2848) While integrating [Knip in the Starter](vivid-planet/comet-starter#560) we've noticed that the API Generator generates an update input for the single generator which isn't used. This is fixed by adding a `generateUpdateInput` option which is set `false` for the single generator.
johnnyomair
reviewed
Dec 10, 2024
manuelblum
force-pushed
the
chore/add-knip
branch
from
4eab0b9 to
8d1c409
Compare
manuelblum
force-pushed
the
chore/add-knip
branch
from
80f666d to
6ce4524
Compare
johnnyomair
reviewed
Dec 10, 2024
johnnyomair
approved these changes
Dec 10, 2024
thomasdax98
approved these changes
Dec 10, 2024
dkarnutsch
approved these changes
Dec 11, 2024
fraxachun
approved these changes
Dec 11, 2024
johnnyomair
added a commit
that referenced
this pull request
Dec 11, 2024
We incorrectly removed `@comet/cli` from the API in #560. The package is used for the site configs type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Knip to lint pipelines. Knip can support in linting dead source code, unused files, unused dependencies, and unnecessary exports.