Re-enable tap to fullscreen behaviour with stricter orientation checks. #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This actually didn't fix the issue, right? A vertical video should stay vertical in portrait when the player goes to full screen. You can test with the my latest owl video on the Video feed. See the video: Screen_recording_20241008_131006.webm |
|
There is also a bug that keeps rotating the phone for images. If I click in the same image, it renders correctly but then rotates when it goes back. If I click again, it renders in that orientation again but rotates again when the full screen closes. Screen_recording_20241008_145733.webm |
vitorpamplona
added a commit
that referenced
this pull request
Oct 8, 2024
|
@vitorpamplona that is strange. Let me check it again. As for the images, the rotation behaviour should not affect them, since the PR only targeted livestreams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue introduced by #1018 .