Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualise a job's arguments #21

Open
itsameandrea opened this issue Jan 18, 2024 · 3 comments
Open

Visualise a job's arguments #21

itsameandrea opened this issue Jan 18, 2024 · 3 comments

Comments

@itsameandrea
Copy link

Hey Vincent!

Something that every once in a while I find myself doing is checking out what arguments a certain job was enqueued with. As far as I can see that bit of information is not rendered for a job.

Do you think it would make sense to add it? Happy to work on a PR for it 👌

@virolea
Copy link
Owner

virolea commented Jan 18, 2024

Hey Andrea!

Definitely worth adding. I could see a UI where I could toggle the arguments from the job list view. I am not sure about displaying the raw arguments in the list, àla Sidekiq. Plus we could take this a bit further by looking up objects passed as global ids to the job.

Anyhow, feel free to take a stab at it 👌!

@itsameandrea
Copy link
Author

Yeah I agree. The raw arguments in the list don't feel great.

Maybe each table row could kinda be like an accordion that you can expand and then more details are shown. Or maybe it could be a simple modal / slideover.

Either way - I'll get a PR ready soon-ish.

@virolea
Copy link
Owner

virolea commented Jan 19, 2024

Great to hear!

Let me know if you need help. I've made some changes on main, I moved the engine from importmaps to esbuild bundles, everything should be working but in case there are any issue let me know!

Feel free to add Stimulus if you need it as well. I am working on a separate branch for a new dashboard and will need it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants