Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /api/v1/places : Additional attributes to be exposed #85

Open
AleziaKurdis opened this issue Apr 20, 2021 · 3 comments
Open

GET /api/v1/places : Additional attributes to be exposed #85

AleziaKurdis opened this issue Apr 20, 2021 · 3 comments

Comments

@AleziaKurdis
Copy link

In order to build explore/goto applications, we would need the following fields to be added to the exposed attributes:

domain.capacity
(This allows to determine when a place is full or not.)

Place Owner Name/username
This data is currently exposed in the current Explore app. It's also a lever to get all the places of the same owner, which can be valuable in an explore app. Ideally, we want the username (to not have to make a second call to the API). It would have been cool to have a display name instead. (But we don't have this.)
If we don't want to provide the username for any security reason, we could work with only the accountID (we could at least extract the places of the same owner without necessarily expose the name/username)

Is anonymous user can access to this domain (Not sure if we have this info on the domain attributes currently)
Since the API is only returning the place where the domain visibility is "open", it would be interesting if we could have a field to indicate if the anonymous users can log in or not. The idea would be to display all the open places but have the place for connected users only displayed disable for anonymous, so they could see what they miss by being anonymous.

@Misterblue
Copy link
Collaborator

"capacity" has been added.
At the moment, the Place "owner" is the domain owner. Wouldn't it be better to have a "contact" account associated with a Place? Something like a list of place managers? This would be a list of account names that are the "managers" of the Place. There is a list of managers for a domain (which will be implemented some day) but how about that for individual places?

@AleziaKurdis
Copy link
Author

To me, the place owner is the user account that created this place name. (until we support multiple manager (domain or place). We could change this in time and return the right values)

It would be useful to have directly the name(s) exposed... to not have to do extra call for each entry when we build the place list.

@Misterblue
Copy link
Collaborator

I added and enabled "managers" for Places. A place now has the attribute "managers" that is an array of usernames who are the managers of the Place. Anyone listed in the manager list can change most of the values of the Place. The list of managers defaults to the username of the hosting domain's owner.

So, you can get the "owner" of the Place by listing the first entry in the "managers" list.

This will be active when Iamus 2.4.5 is deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants