Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependant default env variables #174

Open
viperML opened this issue Nov 19, 2024 · 3 comments
Open

Dependant default env variables #174

viperML opened this issue Nov 19, 2024 · 3 comments
Labels
Milestone

Comments

@viperML
Copy link
Owner

viperML commented Nov 19, 2024

Right now, the Installable args use NH_FILE and NH_ATTRS for all subcommands. It should have an specific env variable for nh os and nh home.

@viperML
Copy link
Owner Author

viperML commented Nov 19, 2024

My first idea is to apply the "default values and env variables" at the run site, instead at the clap parsing site.

The problem with this, is that clap would still show the same description for all commands.

@viperML
Copy link
Owner Author

viperML commented Nov 20, 2024

I've implemented something in #179 but I'm not sure it's the best idea.

@viperML
Copy link
Owner Author

viperML commented Nov 21, 2024

Another option would be to have an specific Installable variant for each subcommand, such that it includes the proper description OsInstallable, etc, and then map it into Installable according to all the fallback values

@viperML viperML added this to the 4.0 Release milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant