Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android Bootcamp] Review my Grid Image Search App #1

Open
vinitpatwa opened this issue Oct 13, 2013 · 1 comment
Open

[Android Bootcamp] Review my Grid Image Search App #1

vinitpatwa opened this issue Oct 13, 2013 · 1 comment

Comments

@vinitpatwa
Copy link
Owner

My App is complete. Please review it. This covers all user stories. /cc @nesquena @timothy1ee

@nesquena
Copy link

Vinit, looks ok. A few notes after checking out the code:

  • Code is super messy in general, tons of stray debug statements and dead code. Consider doing a bit of cleanup before submissions
  • Notice how verbose the managing of the settings filters is here and elsewhere. Read feedback guide for details but consider using an object to encapsulate that complexity and keep it out of the controller (activity)
  • For settings activity you are using EditText but the values are very limited? You should dropdown spinners instead
  • Consider implementing endless pagination as described in the assignment guide

Also, here's provided a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants