Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"range" header is copied from container options even though it should be transitory #494

Open
davedx opened this issue Dec 8, 2021 · 0 comments

Comments

@davedx
Copy link

davedx commented Dec 8, 2021

In lib/requestOptions.js, we do this:

var hds = extend(headers, req.headers, skipHdrs);

But this will also copy the "range" header from the headers variable (which comes from Container.options), even if the client has not set any range header. The result is any requests /after/ a request that used the 'range' header to break up a response will break, often with 416 errors from the origin server, because the range header is still set from a previous resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant