Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxyReqBodyDecorator value is not returned if parseReqBody == false #484

Open
jamonkko opened this issue Jun 3, 2021 · 1 comment
Open

Comments

@jamonkko
Copy link

jamonkko commented Jun 3, 2021

I parse the request body myself before express-http-proxy and set the parsed value with proxyReqBodyDecorator.
But it seems that proxy does not send the self-parsed body.

There is a PR that fixes this already but have not been merged. Please merge it?
#469

This might also fix similar looking issue: #358

@cawoodadviceflow
Copy link

I don't see why parseReqBody = false should mean we have absolutely no access to the body. What if it's an XML string? I see no benefit in this library parsing the body in 2 known formats (x-ww-form-urlencoded or json) or else nothing is accessible. Just provide req.body as a string and let developers use other libraries or JSON.parse() to do the parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants