diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml new file mode 100644 index 00000000000..c1e89f5024e --- /dev/null +++ b/.github/workflows/golangci-lint.yml @@ -0,0 +1,35 @@ +# REF: https://github.com/golangci/golangci-lint-action + +name: GO Lint Check + +on: + push: + branches: [master, release*] + pull_request: + branches: [] + workflow_dispatch: + +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + +jobs: + golangci: + name: lint + runs-on: ubuntu-latest + timeout-minutes: 5 + steps: + - name: Set up Go + uses: actions/setup-go@v4 + with: + go-version: 1.21.x + + - name: Check out code + uses: actions/checkout@v2 + + - name: Go Lint + uses: golangci/golangci-lint-action@v3 + with: + only-new-issues: true + version: v1.55.2 + args: --go=1.21 --config=golangci.yml diff --git a/.golangci.yml b/.golangci.yml new file mode 100644 index 00000000000..7cc0d8f45cc --- /dev/null +++ b/.golangci.yml @@ -0,0 +1,26 @@ +run: + timeout: 5m + issues-exit-code: 2 + +output: + format: colored-line-number,github-actions + print-issued-lines: false + print-linter-name: true + uniq-by-line: false + path-prefix: "" + sort-results: true + +# REF: https://golangci-lint.run/usage/linters/ +linters: + disable-all: true + enable: + - asciicheck + - errorlint + - gosec + - importas + - prealloc + - unconvert + - stylecheck + - unparam + - errcheck + - gofmt diff --git a/cmd/agent/main.go b/cmd/agent/main.go index 7457ebe2808..825f5d3f071 100644 --- a/cmd/agent/main.go +++ b/cmd/agent/main.go @@ -74,12 +74,12 @@ var ( const ( // reportingPeriod is the interval of time between reporting stats by queue proxy. - reportingPeriod = 1 * time.Second + reportingPeriod = 1 * time.Second // Duration the /wait-for-drain handler should wait before returning. // This is to give networking a little bit more time to remove the pod // from its configuration and propagate that to all loadbalancers and nodes. - drainSleepDuration = 30 * time.Second + drainSleepDuration = 30 * time.Second ) type config struct {