Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks to add observability? #7

Open
hairyhenderson opened this issue Nov 22, 2019 · 0 comments
Open

Hooks to add observability? #7

hairyhenderson opened this issue Nov 22, 2019 · 0 comments

Comments

@hairyhenderson
Copy link

Hi @victorspringer, first of all - thanks for a great project. http-cache is simple to use and has met all of my needs so far!

Recently I've been trying to gain more insight into the performance of one of my applications, and especially to figure out just how much impact the cache is having. I've been able to gather some simple metrics by shimming in an adapter, but there's significant context lost.

I'm wondering if you'd be open to expanding the API a bit to run some optional "observer" functions at certain times? I'm thinking specifically it would be useful to get a handle on the request or at least the request's context even in the case of a cache hit.

I'm willing to submit a PR for this work, but wanted to get your feedback first to see if this is something you're even interested in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant