Bug: retrying to delete message counts as a new message

[Liggliluff]

Here's a part of the code, manually redacted, featuring date-time, and the message replaced with a letter:

Searching next messages in 100ms...	
Total messages found: 4242	(Messages in current page: 25, To be deleted: 25, System: 0)	offset: 0
Delete delay: 2382ms, Search delay: 100ms	Last Ping: 435ms, Average Ping: 323ms
Estimated time remaining: 3h 11m 32s
12.16% (587/4826)	Deleting ID:REDACTED REDACTED (2017-11-05 00:40:12): A	
12.18% (588/4826)	Deleting ID:REDACTED REDACTED (2017-11-05 00:12:17): B	
12.20% (589/4826)	Deleting ID:REDACTED REDACTED (2017-11-05 00:12:10): C	
Being rate limited by the API for 847ms! Adjusted delete delay to 847ms.
Delete delay: 847ms, Search delay: 100ms	Last Ping: 285ms, Average Ping: 311ms
Cooling down for 1694ms before retrying...
12.23% (590/4826)	Deleting ID:REDACTED REDACTED (2017-11-05 00:12:10): C	
12.25% (591/4826)	Deleting ID:REDACTED REDACTED (2017-11-05 00:12:02): D	
Being rate limited by the API for 885ms! Adjusted delete delay to 885ms.
Delete delay: 885ms, Search delay: 100ms	Last Ping: 270ms, Average Ping: 303ms
Cooling down for 1770ms before retrying...
12.27% (592/4826)	Deleting ID:REDACTED REDACTED (2017-11-05 00:12:02): D	
12.29% (593/4826)	Deleting ID:REDACTED REDACTED (2017-11-05 00:11:02): E	
Being rate limited by the API for 775ms! Adjusted delete delay to 775ms.
Delete delay: 775ms, Search delay: 100ms	Last Ping: 267ms, Average Ping: 298ms
Cooling down for 1550ms before retrying...
12.31% (594/4826)	Deleting ID:REDACTED REDACTED (2017-11-05 00:11:02): E	
12.33% (595/4826)	Deleting ID:REDACTED REDACTED (2017-11-05 00:08:29): F	
Being rate limited by the API for 651ms! Adjusted delete delay to 651ms.
Delete delay: 651ms, Search delay: 100ms	Last Ping: 706ms, Average Ping: 337ms
Cooling down for 1302ms before retrying...
12.35% (596/4826)	Deleting ID:REDACTED REDACTED (2017-11-05 00:08:29): F	
12.37% (597/4826)	Deleting ID:REDACTED REDACTED (2017-11-04 23:38:48): G	

Each time it retries, it counts it as a new message, making the current progress be wrong. Message G should be number 593/4826 and not 597/4826.

[victornpb]

Yeah that specific bug has been addressed in the next version, I caught it while refactoring the code.

But the progress still not perfect because

1. discord search doesn't always reliably report results
2. a person can type more messages while you're deleting so the progress will get above 100%.
3. we can't predict if a message can't be deleted ahead of time, so the total is sometimes kinda bogus.

So I don't know if that is something that even worth trying to get accurate. I would take it more like a rough estimate of progress.

[Liggliluff]

While that is true, it could automatically adjust the number as it progresses. It has a counter for number of deleted messages, and one for messages it couldn't delete. It then also know how many messages it found in total last time it checked.

So it can say: (messages deleted) / (messages deleted + last total message count)