Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle encoder overflow. #48

Open
markwomack opened this issue Apr 12, 2017 · 3 comments
Open

Handle encoder overflow. #48

markwomack opened this issue Apr 12, 2017 · 3 comments
Assignees

Comments

@markwomack
Copy link
Contributor

In doReadEncoders() is probably the ideal place to handle it.

@markwomack markwomack self-assigned this Apr 12, 2017
@markwomack
Copy link
Contributor Author

I have been running some tests on my TReX rig, to see what happens when the encoder count overflows from both MAX_LONG to MIN_LONG and vica versa (the encoder lib allows a value to be written, so I don't have to wait forever to set up the overflow). I don't see a problem. If we subtract the previous reading from the new reading, the difference will always be correct across the boundary. Am I missing something here?

@griswaldbrooks
Copy link
Contributor

griswaldbrooks commented Apr 14, 2017 via email

@markwomack
Copy link
Contributor Author

Thus my confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants