Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you accept a PR adding support for Line-Awesome? #97

Open
tabacitu opened this issue Nov 20, 2020 · 0 comments
Open

Would you accept a PR adding support for Line-Awesome? #97

tabacitu opened this issue Nov 20, 2020 · 0 comments

Comments

@tabacitu
Copy link

Hi @victor-valencia ,

Thanks a lot for the good work you've been doing on this project. Super-appreciate it.

The Problem

Some of us use a free font-awesome alternative, called line-awesome. It has all font-awesome icons, but thinner. Which we found to be more appropriate in some Bootstrap projects. We've been using it for years and we're happy with it.

But. They use a different class prefix: la la-home instead of fa fa-home. So we can't natively use it inside bootstrap-datepicker (it seems).

The Solution

If you also think it would be a good idea to support it, we (the team from Backpack for Laravel) can:

  • create a PR to add line-awesome support, and work on it until you're happy;
  • promise to provide any and all bug fixing for that part going forward;

We know how it is to have to maintain someone else's features, and we don't want this to be a maintenance burden to you.


  1. What do you think - if we submit a PR will you merge it? Is it a feature you want?
  2. Is there another better way to do it without modifying the core? If so could you point us in the right direction.

I'll mention @promatik here because he's part of the official Backpack team, but he's also provided a PR to your repo in the past, so he's the best man for the job, I think.

Eager to hear your response @victor-valencia , even if it's a "no". Thanks again for your work.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant