Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skill rewards from artefact skills are paid out incorrectly #206

Open
Christoph-Meyer opened this issue Mar 28, 2019 · 0 comments
Open

Skill rewards from artefact skills are paid out incorrectly #206

Christoph-Meyer opened this issue Mar 28, 2019 · 0 comments
Labels
bug An error that needs to be fixed

Comments

@Christoph-Meyer
Copy link
Collaborator

Scenario:

  • User buys an artefact without skill
  • Solves a task
  • a reward for aan artefact skill is paid out (X)

2019-03-28 14:31:14.607 INFO [sQ,a02a0e91ca656e91,a02a0e91ca656e91,false] 1 --- [o-8080-exec-134] c.v.s.services.GratificationService : Task AWiCAlc378MIs-jysIrI solved - Rewarding userID 5 with 2 gold and 7 xp
2019-03-28 14:31:14.609 INFO [sQ,a02a0e91ca656e91,a02a0e91ca656e91,false] 1 --- [o-8080-exec-134] c.v.s.services.GratificationService : Adding skill rewards to user ID 5 - extra gold 3 and extra xp 0
^^
this is wrong!

Bug requires extensive testing :(

@Christoph-Meyer Christoph-Meyer added the bug An error that needs to be fixed label Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error that needs to be fixed
Projects
None yet
Development

No branches or pull requests

1 participant