Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loader dry run #558

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nosnelmil
Copy link
Contributor

@nosnelmil nosnelmil commented Nov 16, 2024

Summary

Adds a dry run flag to the loader, enabling users to execute the loader without generating trace loads or running experiments. Also adds a simple validation for cpu limit field in loader config.

Implementation Notes ⚒️

  • Add a dryRun flag to the loader which accepts a boolean value.
  • Modifies the execution flow to exit early by checking the dryRun flag just before calling RunExperiment via the experiment driver in the runTraceMode function
  • Add a simple validation to ensure provided cpu limit in loader config is valid

External Dependencies 🍀

  • N/A

Breaking API Changes ⚠️

  • N/A

Simply specify none (N/A) if not applicable.

@leokondrashov
Copy link
Contributor

I think you forgot the CPU limit check that we were talking about, please add it

@nosnelmil
Copy link
Contributor Author

I think you forgot the CPU limit check that we were talking about, please add it

Oh yes, thought I will be adding that in another PR, will add that in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants