Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some build-time programs optional #6

Open
alexrp opened this issue Jun 10, 2024 · 2 comments
Open

Make some build-time programs optional #6

alexrp opened this issue Jun 10, 2024 · 2 comments
Assignees
Labels
area: build Issues related to the build system. state: blocked Issues that are blocked on some other issue or work.
Milestone

Comments

@alexrp
Copy link
Member

alexrp commented Jun 10, 2024

graf/build.zig

Lines 13 to 16 in 5267fa7

// TODO: https://github.com/ziglang/zig/issues/15373
const pandoc_prog = b.findProgram(&.{"pandoc"}, &.{}) catch @panic("Could not locate `pandoc` program.");
const npm_prog = b.findProgram(&.{"npm"}, &.{}) catch @panic("Could not locate `npm` program.");
const code_prog = b.findProgram(&.{"code"}, &.{}) catch @panic("Could not locate `code` program.");

# TODO: Remove this hack when `code` is made optional.
- name: Workaround for issue 6
run: |
mkdir hack
touch hack/code
echo "$PWD/hack" >> $GITHUB_PATH

code, at least, should be optional.

Requires:

@alexrp alexrp added area: build Issues related to the build system. state: blocked Issues that are blocked on some other issue or work. type: housekeeping labels Jun 10, 2024
@alexrp alexrp added this to the Future milestone Jun 10, 2024
@alexrp alexrp assigned alexrp and unassigned alexrp Jun 10, 2024
alexrp added a commit that referenced this issue Jun 16, 2024
@alexrp alexrp self-assigned this Jun 16, 2024
@alexrp alexrp modified the milestones: Future, v1.0 Jun 16, 2024
@alexrp
Copy link
Member Author

alexrp commented Jun 17, 2024

Will be done when we update to Zig 0.14.0.

alexrp added a commit that referenced this issue Jun 17, 2024
alexrp added a commit that referenced this issue Jun 17, 2024
@alexrp
Copy link
Member Author

alexrp commented Jun 17, 2024

d4118f5 is working around this until the Zig update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Issues related to the build system. state: blocked Issues that are blocked on some other issue or work.
Projects
None yet
Development

No branches or pull requests

1 participant