Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aro and libffi should be optional, lazy dependencies #16

Open
alexrp opened this issue Jun 16, 2024 · 2 comments
Open

Aro and libffi should be optional, lazy dependencies #16

alexrp opened this issue Jun 16, 2024 · 2 comments
Labels
area: infrastructure Issues related to infrastructure (GitHub, CI, etc). state: blocked Issues that are blocked on some other issue or work.
Milestone

Comments

@alexrp
Copy link
Member

alexrp commented Jun 16, 2024

graf/build.zig

Lines 103 to 107 in 662bf28

// TODO: Aro should be a lazy dependency, but this causes HTTP problems on macOS.
graf_mod.addImport("aro", b.dependency("aro", .{
.target = target_opt,
.optimize = optimize_opt,
}).module("aro"));

Making it lazy causes CI failures: https://github.com/vezel-dev/graf/actions/runs/9533073069/job/26275888084

Upstream bug:

@alexrp alexrp added area: infrastructure Issues related to infrastructure (GitHub, CI, etc). state: blocked Issues that are blocked on some other issue or work. type: bug labels Jun 16, 2024
@alexrp alexrp added this to the Future milestone Jun 16, 2024
alexrp added a commit that referenced this issue Jun 16, 2024
@alexrp alexrp modified the milestones: Future, v1.0 Jun 16, 2024
@alexrp
Copy link
Member Author

alexrp commented Jun 16, 2024

Applied a workaround in 662bf28.

@alexrp alexrp changed the title macos-14 CI is failing to fetch dependencies Aro should be an optional, lazy dependency Jun 16, 2024
@alexrp alexrp changed the title Aro should be an optional, lazy dependency Aro and libffi should be optional, lazy dependencies Jun 21, 2024
@alexrp
Copy link
Member Author

alexrp commented Jun 21, 2024

This should also be done for libffi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: infrastructure Issues related to infrastructure (GitHub, CI, etc). state: blocked Issues that are blocked on some other issue or work.
Projects
None yet
Development

No branches or pull requests

1 participant