Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace xmlrpc with maintained package? #18

Open
ajmas opened this issue Aug 31, 2021 · 4 comments
Open

Replace xmlrpc with maintained package? #18

ajmas opened this issue Aug 31, 2021 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@ajmas
Copy link
Contributor

ajmas commented Aug 31, 2021

I recently ran into this issue, with odoo-await (caused by connecting to http port 80, while specifying https):

Error: write EPROTO 140596194441088:error:1408F10B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:332:

While investigating the issue it came to my attention that the xmlrpc library this project depends on has not been maintained for 5 years, and many of its dependencies for just as long. Given this, would it make sense to replace xmlrpc with a package that is currently maintained?

Edit: Looking around, I am not sure there is a good replacement. Some appear to be unmaintained forks, while others lack documentation, such as @foxglove/xmlrpc . Its possible that the unmaintained 5 year old package is still suitable?

@vettloffah
Copy link
Owner

vettloffah commented Sep 1, 2021

Thanks for the suggestion, looking into this. But yeah, back when I first published the library I did some research and couldn't find any suitable replacements. Not sure if things have changed.

@vettloffah vettloffah added the help wanted Extra attention is needed label May 17, 2022
@vettloffah
Copy link
Owner

I discovered a new package here: https://www.npmjs.com/package/@foxglove/xmlrpc

It is meant to support one of the company's software products, but I think it would work as a general XML RPC client. I asked in their slack channel and they confirmed it should.

@RicardoViteriR
Copy link

Hi @vettloffah, what would be the general strategy to migrate to this package?

  1. Setup testing environment with current tests
  2. Migrate methods to the new client

@vettloffah
Copy link
Owner

Yes that should do it @RicardoViteriR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants