Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color argument in qhistogram is not working #23

Open
vertesy opened this issue Dec 13, 2021 · 1 comment
Open

color argument in qhistogram is not working #23

vertesy opened this issue Dec 13, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@vertesy
Copy link
Owner

vertesy commented Dec 13, 2021

Description
color argument in qhistogram is not working

condiitions 2 and 3 seem nonsense:
(prob from qbarplot)

  df[["colour"]] <- if (vline & filtercol != 0) {
    if (filtercol == 1 ) (df$"value" > vline) else if (filtercol == -1 ) (df$"value" < vline)
  } else if (length(col) == length(vec)) {
    as.character(col)
  } else {
    as.character(rep(col, length(vec))[1:length(vec)])
  }

@vertesy vertesy added the bug Something isn't working label Dec 13, 2021
@vertesy
Copy link
Owner Author

vertesy commented Sep 12, 2024

Related to #33

Here’s the formatted document with the provided content, including code blocks using backticks:

### Sampling and basic qhistogram
```r
xxx <- sample(1:100, 10000, replace = TRUE)
qhistogram(xxx)

Palette works

qhistogram(xxx, palette_use = "aaas")

Color does not work

qhistogram(xxx, col = 1,
           vline = 33, filtercol = TRUE,
           suffix = "madonna", save = FALSE)

Using explicit color

qhistogram(xxx, col = "brown",
           vline = 33, filtercol = TRUE,
           suffix = "madonna", save = FALSE)

Let me know if you need further edits!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant