0.18.0: missing libcrypto detection

[kloczek]

Looks like there is missing in autoconf libbcrypto detction.

/usr/bin/g++ -std=c++11 -DHAVE_CONFIG_H -I. -I../src/config   -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -DUSE_SSE2=1  -fstack-reuse=none -Wstack-protector -fstack-protector-all -fcf-protection=full -fstack-clash-protection      -fPIE -O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none -fno-extended-identifiers -fvisibility=hidden -c -o crypto/libbitcoin_crypto_base_a-scrypt.o `test -f 'crypto/scrypt.cpp' || echo './'`crypto/scrypt.cpp
crypto/scrypt.cpp: In function ‘void PBKDF2_SHA256(const uint8_t*, size_t, const uint8_t*, size_t, uint64_t, uint8_t*, size_t)’:
crypto/scrypt.cpp:112:15: warning: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘class CHMAC_SHA256’; use assignment instead [-Wclass-memaccess]
  112 |         memset(&PShctx, 0, sizeof(CHMAC_SHA256));
      |         ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from crypto/scrypt.cpp:35:
crypto/hmac_sha256.h:14:7: note: ‘class CHMAC_SHA256’ declared here
   14 | class CHMAC_SHA256
      |       ^~~~~~~~~~~~
/usr/bin/g++ -std=c++11 -DHAVE_CONFIG_H -I. -I../src/config   -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -DUSE_SSE2=1  -fstack-reuse=none -Wstack-protector -fstack-protector-all -fcf-protection=full -fstack-clash-protection      -fPIE -O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none -fno-extended-identifiers -fvisibility=hidden -c -o crypto/libbitcoin_crypto_base_a-scrypt-sse2.o `test -f 'crypto/scrypt-sse2.cpp' || echo './'`crypto/scrypt-sse2.cpp
crypto/scrypt-sse2.cpp:36:10: fatal error: openssl/sha.h: No such file or directory
   36 | #include <openssl/sha.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [Makefile:11018: crypto/libbitcoin_crypto_base_a-scrypt-sse2.o] Error 1
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/vertcoin-core-0.18.0/src'
make[1]: *** [Makefile:19964: all-recursive] Error 1
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/vertcoin-core-0.18.0/src'
make: *** [Makefile:808: all-recursive] Error 1
[tkloczko@pers-jacek vertcoin-core-0.18.0]$ rpm -q openssl-devel

[kloczek]

After add openssl-devel to build env I was able to build vertcoin.

[vertiond]

Thanks for the report! What OS?

[kloczek]

Linux x86/64

[kloczek]

Nevertheless this issue does not depend on OS type.