-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mode Change #129
base: main
Are you sure you want to change the base?
Mode Change #129
Conversation
❌ Deploy Preview for find-me-issues failed.
|
❌ Deploy Preview for find-me-issues-web-app failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some stuff being added as per a submodule which comes from default react application, I doubt this was intended would request you to check this again
@@ -0,0 +1,2 @@ | |||
[submodule "Find-Me-Issues"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the submodule needed in the final commit?
@@ -0,0 +1,25 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for adding all the default react icon set and config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default icon set and manifest.json
enable PWA functionality, ensuring proper display across devices, customizable theming, and future-readiness for app installation.
src/Context/themeContext.js
Outdated
|
||
// export function ThemeProvider(props) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't leave comments if they are not adding any value to the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I will remove it
Update themeContext.js.Able to solve page reload mode change issue.