Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mode Change #129

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Mode Change #129

wants to merge 7 commits into from

Conversation

snehautekar05
Copy link

Update themeContext.js.Able to solve page reload mode change issue.

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for find-me-issues failed.

Name Link
🔨 Latest commit 1d99f48
🔍 Latest deploy log https://app.netlify.com/sites/find-me-issues/deploys/6717b858ada2170008e9e308

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for find-me-issues-web-app failed.

Name Link
🔨 Latest commit 1d99f48
🔍 Latest deploy log https://app.netlify.com/sites/find-me-issues-web-app/deploys/6717b8582d42410008fdc894

Copy link
Owner

@version0chiro version0chiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some stuff being added as per a submodule which comes from default react application, I doubt this was intended would request you to check this again

@@ -0,0 +1,2 @@
[submodule "Find-Me-Issues"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the submodule needed in the final commit?

@@ -0,0 +1,25 @@
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for adding all the default react icon set and config?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default icon set and manifest.json enable PWA functionality, ensuring proper display across devices, customizable theming, and future-readiness for app installation.


// export function ThemeProvider(props) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't leave comments if they are not adding any value to the code

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants