Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does authentication send my token to an HTTP site? (seanallred) #314

Closed
Hunter-Github opened this issue Jan 11, 2016 · 19 comments
Closed

Comments

@Hunter-Github
Copy link

Can't understand the process. Does that mean access to my account is shared by a dozen other folks?

@vermiculus
Copy link
Owner

No, your account is not shared with anyone.

@Hunter-Github
Copy link
Author

Why an insecure redirect, then?

@Hunter-Github
Copy link
Author

I must be missing something obvious, please bear with me. If you have an RTFM link handy, that'll do.

@vermiculus
Copy link
Owner

The authentication is handled entirely by StackExchange.

image

As you can see, I don't provide the protocol -- just the domain.

@Hunter-Github
Copy link
Author

Ah ok, thanks.

@vermiculus
Copy link
Owner

Hmm, actually it's defined by a variable here:

(defconst sx-auth-redirect-uri

@vermiculus vermiculus reopened this Jan 11, 2016
@vermiculus
Copy link
Owner

Can you change the value of that constant to use https and see if it still works for you? If it does, I'll change in master.

@Hunter-Github
Copy link
Author

Changed, the redirect URI has changed but since the seanallred.com listens only on HTTP, it did not pull the page.

@vermiculus
Copy link
Owner

That's something with GitHub pages that I cannot fix, then. 😦

@vermiculus
Copy link
Owner

Well.... maybe. I'll have to screw around with my domain settings later tonight, but I'll give it a shot.

@Hunter-Github
Copy link
Author

Many thanks in advance. Don't sweat it, though, the app was recommended by Gilles but I can live without it.

@Hunter-Github
Copy link
Author

Relevant Sec.SE answer: https://security.stackexchange.com/a/66138

@vermiculus
Copy link
Owner

For as long as I use GitHub Pages for my blog, this won't really be possible (until GitHub makes some changes with its SSL cert strategy).

Just so you're aware, only the authentication token is sent unsecurely.

  1. Unless you're on public wifi, I really wouldn't worry about it.
  2. You can revoke this authentication token at any time. It's not related to your password.

I'm going to leave this issue open in hopes that GitHub makes this possible or that my blog moves to another host. But for now, there's nothing I can do.

@Malabarba
Copy link
Collaborator

Yeah, I looked into it for my blog as well, but gh-pages just doesn't do https ATM.

@Hunter-Github
Copy link
Author

Okay, thanks.

@RockyRoad29
Copy link
Contributor

I was not able to get an OAuth token
M-x sx-authenticate sends me to uri (I obliterated here the client-id) https://stackoverflow.com/oauth/dialog?client_id=####&redirect_uri=http%253A%252F%252Fseanallred.com%252Fsx.el%252Fauth%252Fauth.htm&scope=read_inbox%2cno_expiry%2cprivate_info%2cwrite_access.
The server answers:
http%3A%2F%2Fseanallred.com%2Fsx.el%2Fauth%2Fauth.htm is not a valid uri

I tried adding setting by hand https in the redirect_uri, it doesn't help.
As I couldn't figure out how removing the https from the request uri would be secure, It didn't try it.

But I think the redirect_uri looks like encoded twice.

@vermiculus
Copy link
Owner

But I think the redirect_uri looks like encoded twice.

You're right on the money there. This is unrelated to this issue, though; can you open a new one?

@RockyRoad29
Copy link
Contributor

RockyRoad29 commented Feb 13, 2018

Sure. See issue #349 and PR #350

@vermiculus
Copy link
Owner

GitHub Pages now supports HTTPS, so this has been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants