Set MKey as uint #34
Set MKey as uint #34
Conversation
yogeshbdeshpande
force-pushed
the
mkey_issue_32_branch
branch
2 times, most recently
from
8da15cd
to
09fcc2c
Compare
yogeshbdeshpande
force-pushed
the
mkey_issue_32_branch
branch
3 times, most recently
from
ea7b1c7
to
c71d7d4
Compare
comid/measurement_test.go
Outdated
| fmt.Printf("CBOR: %x\n", actual) | ||
| } | ||
| } | ||
| func TestMkey_MarshalCBOR_uint_notok(t *testing.T) { |
There was a problem hiding this comment.
| func TestMkey_MarshalCBOR_uint_notok(t *testing.T) { | |
| func TestMkey_MarshalCBOR_uint_not_ok(t *testing.T) { |
There was a problem hiding this comment.
this test does not seem specific to uint mkeys
There was a problem hiding this comment.
if we have one single test vector using a table is superfluous.
comid/measurement_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func TestMkey_UnmarshalCBOR_uint_notok(t *testing.T) { |
There was a problem hiding this comment.
I'd expect the test vectors here to be such that GetKeyUint fails rather than the failure happening on the generic mkey unmarshaler
There was a problem hiding this comment.
Not clear what you are saying here!
In UnMarshal CBOR a Byte stream will be passed to the decoder. If an invalid data is passed, then
it should fail Unmarshaling.
If the Unmarshal is a success, then GetKeyUint will never fail ?
There was a problem hiding this comment.
Anyway I think, I understood what you are trying to say, have corrected it now!
comid/measurement_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func TestMkey_MarshalJSON_uint_notok(t *testing.T) { |
There was a problem hiding this comment.
Same set of comments as above:
- we have one only vector therefore we don't need a full-blown table driven test
but most importantly: - there is nothing specific to the uint mkey that is tested here
There was a problem hiding this comment.
For 1. I agree, that I will perhaps add one more test so that it is justified to have a table driven logic.
comid/measurement_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func TestMkey_UnmarshalJSON_uint_notok(t *testing.T) { |
There was a problem hiding this comment.
I'd expect the test vectors here to be such that GetKeyUint fails rather than the failure happening on the generic mkey unmarshaler
There was a problem hiding this comment.
Same comment here, as above!
yogeshbdeshpande
force-pushed
the
mkey_issue_32_branch
branch
from
b25061f
to
578b61e
Compare
comid/measurement_test.go
Outdated
| assert.EqualError(t, err, expectedErr) | ||
| } | ||
|
|
||
| func TestMeasurement_MarshalCBOR_uint_mkey_ok(t *testing.T) { |
There was a problem hiding this comment.
| func TestMeasurement_MarshalCBOR_uint_mkey_ok(t *testing.T) { | |
| func TestMKey_MarshalCBOR_uint_ok(t *testing.T) { |
comid/measurement_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func TestMkey_UnmarshalCBOR_uint_not_ok(t *testing.T) { |
There was a problem hiding this comment.
Test for Mkey as Valid but Not a Uint Mkey
|
Cool. One last thing: it seems that we can increase the coverage threshold to 84.4% now! |
|
Yes! |
can you move the needle in |
|
Sure will do! |
|
Ambit in an another PR |
No description provided.