Pass schema into api extension definition

[sonntag-philipp]

Description

See #3165

Breaking changes

As JavaScript behaves this way, no breaking changes should be included:

Checklist

📌 Always:

• I have set a clear title
• My PR is small and contains a single feature
• I have checked my own PR

👍 Most of the time:

• I have added or updated test cases
• I have updated the README if needed

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	Dec 17, 2024 3:30pm

[sonntag-philipp]

Please let me know where to add tests for this. I will add them if necessary.

[sonntag-philipp]

I am not quire sure where the schema can be passed here.

[michaelbromley]

That's a tough one. The resolvers() function is called from here and ultimately the call comes from here:

/**
 * The internal module containing the Shop GraphQL API resolvers
 */
@Module({
    imports: [ApiSharedModule, ...createDynamicGraphQlModulesForPlugins('shop')],
    providers: [...shopResolvers, ...entityResolvers],
    exports: [...shopResolvers],
})
export class ShopApiModule {}

which means at that point we don't have access to the schema object at all. There might be some way to refactor this by using some kind of dynamic module pattern. This would be quite advanced but I think should be possible.

[michaelbromley]

Hi, thanks for the contribution. This is a good addition.

Is the schema also needed in the resolvers() function because you will be dynamically creating a resolver class/object?

[sonntag-philipp]

@michaelbromley thanks for the insights on the resolvers!

I think for my specific use-case it would be sufficient to just pass the current schema to the schema() method, even though passing the schema to the resolvers would be nice to have for the cases you mentioned.

I will remove the changes to the resolvers(), so this can be merged in the near future :)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud