Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onActivate and onDeactivate should be implemented at the PromotionItemAction level #3255

Open
mschipperheyn opened this issue Dec 3, 2024 · 0 comments

Comments

@mschipperheyn
Copy link
Collaborator

mschipperheyn commented Dec 3, 2024

Is your feature request related to a problem? Please describe.
In order to process promotion that impact at the orderLine level, the PromotionItemAction has your back. But the side effects are still Order based. Worse, the state is not passed along requiring you to effectively rerun your condition to identify the orderLines you want to update

Relates to #3254

Describe the solution you'd like
implement onActivate and onDeactivate at the PromotionItemAction level, passing the OrderLine in question

Describe alternatives you've considered
rerunning the condition logic

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant