fix(e2e): Use VITEST_WORKER_ID to generate test server ports #3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Well, this failed miserably. Apparently learn runs the asset server e2e tests, the elasticsearch plugin e2e tests, and the payments plugin e2e tests in parallel, in separate vitest processes. In a normal repository, the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3247. Instead of using unsynchronized access to a temporary file to determine the next available port, it uses the
VITEST_WORKER_IDenvironment variable, which should be unique in each test suite, to figure out what port it should be using.Breaking changes
Nope, it only applies to the internal test configuration used in Vendure's e2e self-tests.
Checklist
📌 Always:
👍 Most of the time: