Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): updated docs for wishlist plugin #3242

Conversation

Rana-Faraz
Copy link
Contributor

added await to db query causing the value to be promise and causing server crash

Issue#2868

Description

If you run the addToWhishlist mutation twice then the server crashes with the error:

if (this.isReleased) throw new QueryRunnerAlreadyReleasedError()
                                  ^
QueryRunnerAlreadyReleasedError: Query runner already released. Cannot run queries anymore.

in simple words

If the variant is already in the wishlist and you run the mutation again (trying to add a variant to wishlist when that variant is already in the wishlist) the server crashes.

Breaking changes

No breaking changes.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

added await to db query causing the value to be promise and causing server crash

Issue#2868
Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 27, 2024 0:25am

Copy link
Contributor

github-actions bot commented Nov 27, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Rana-Faraz
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 27, 2024
@michaelbromley michaelbromley merged commit 121055b into vendure-ecommerce:master Nov 29, 2024
28 of 30 checks passed
@michaelbromley
Copy link
Member

thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants